This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix for bz#13658 - using fsincos on x86-64


On Fri, 24 Feb 2012, Carlos O'Donell wrote:

> On Fri, Feb 24, 2012 at 11:01 AM, Andreas Jaeger <aj@suse.com> wrote:
> > I can add a couple of testcases. How do we want to continue? Should we use
> > the patch to fix the double case - and then later handle long double, or do
> > you want everything fixed at the same time?
> 
> Andreas, Thanks for helping!
> 
> Incremental improvement is the best way forward in my opinion.

Agreed.

> * Fix the double case.

Yes.  For 32-bit x86 it looks like all of float, double and long double 
are affected (float and double should be easy to fix).

> * File a new bugzilla issue to fix the long double case noting
> Joseph's suggestion.

Yes.  Point to this discussion.

> * Add new test cases to cover the problem.

Yes.  If necessary, disable them for the affected long double format, with 
a comment pointing to the new bug (rather than adding enormous numbers of 
ulps as expected for the new tests for long double).

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]