This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: include sys/param.h in getcwd.c
- From: "Carlos O'Donell" <carlos at systemhalted dot org>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: Mike Frysinger <vapier at gentoo dot org>, libc-alpha at sourceware dot org
- Date: Wed, 15 Feb 2012 13:40:34 -0500
- Subject: Re: include sys/param.h in getcwd.c
- References: <200606180250.19479.vapier@gentoo.org><Pine.LNX.4.64.1202151807050.1671@digraph.polyomino.org.uk>
On Wed, Feb 15, 2012 at 1:10 PM, Joseph S. Myers
<joseph@codesourcery.com> wrote:
> I came across this 2006 patch
> <http://sourceware.org/ml/libc-alpha/2006-06/msg00068.html> in the course
> of reviewing bugs. ?I think it should go in as an obvious fix - source
> files should use well-defined APIs of the headers they include rather than
> relying on long indirect include paths for internal headers. ?Comments?
I fully agree. Please check this fix into trunk. For several years I
carried a similar patch locally because the hppa header layout did not
pull in MAX.
Cheers,
Carlos.