This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Provide crt[in].S for x86-64


On 02/08/2012 03:38 PM, Marek Polacek wrote:
This is an attempt to add sysdeps/x86_64/crt[in].S support.  I mostly
followed crt[in].S from i386 dir and from builddir/csu.  It looks like
it works, but I don't know how to test this properly apart from running
something like this:

#include<stdio.h>
#include<gnu/libc-version.h>

static void __attribute__ ((constructor))
con (void)
{
   puts ("con");
}

static void __attribute__ ((destructor))
dest (void)
{
   puts ("dest");
}

int
main (void)
{
   puts (gnu_get_libc_version ());
}

It compiles both on x86_64-unknown-linux-gnu and x86_64-redhat-linux and
the aforementioned program runs fine as well.
I'm not attaching the CL entry, license etc yet, I'll do this later.  It also looks
like we don't need any CFLAGS tweak (e.g. like on i386 with
-fno-asynchronous-unwind-tables).  I think we should also remove
sysdeps/x86_64/elf/initfini.c file later on--this will not be needed any more.

So, comments, please? Thanks,

Looks good to me. I suggest to remove initfini.c at the same time you commit this,


thanks,
Andreas
--
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]