This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [tile] support openat() in not-cancel.h
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Chris Metcalf <cmetcalf at tilera dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 26 Jan 2012 14:03:19 -0800 (PST)
- Subject: Re: [tile] support openat() in not-cancel.h
- References: <201111100054.pAA0sf6u025585@farm-0002.internal.tilera.com><CAOPLpQeYkCxui8-tfzrwRzu1fTe8qbMQ7k4Ar5mM+Ja2VoUp8g@mail.gmail.com><4EBD94B4.4050009@tilera.com><4EBD9A81.7030601@tilera.com><20111111221503.333BA2C102@topped-with-meat.com><201201252127.q0PLRkRk027118@farm-0002.internal.tilera.com>
> /* Uncancelable versions of cancelable interfaces. Linux version.
> - Copyright (C) 2003, 2006 Free Software Foundation, Inc.
> + Copyright (C) 2003, 2006, 2011 Free Software Foundation, Inc.
It's 2012.
> #include <sys/types.h>
> #include <sysdep.h>
> +#ifndef __NR_open
> +# include <fcntl.h>
> +#endif
It's probably easier all around on maintenance not to conditionalize this
#include. It doesn't hurt to have it when it's not needed.
> +# error "Neither __NR_open nor __NR_openat available."
s/available/is &/
Thanks,
Roland