This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][sh] Fix iov[] size in register_dump()

From: Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>
To: takashi dot yoshii dot zj at renesas dot com
Cc: schwab at redhat dot com, libc-alpha at sourceware dot org
Date: Wed, 26 May 2010 23:20:07 +0900 (JST)
Subject: Re: [PATCH][sh] Fix iov[] size in register_dump()
References: <20100525185756.ce254757.takashi.yoshii.zj@renesas.com><20100525.214336.72388992.kkojima@rr.iij4u.or.jp><20100526164830.978d73cd.takashi.yoshii.zj@renesas.com>

takashi.yoshii.zj@renesas.com wrote:
> I think, using more magic numbers might looks less magical.
> +  struct iovec iov[22*2 + 34*2 + 2];
[snip]

Agreed.

Uli, could you please approve the patch in

http://sourceware.org/ml/libc-alpha/2010-05/msg00046.html

?

Regards,
	kaz

References:
- [PATCH][sh] Fix iov[] size in register_dump()
  - From: takashi . yoshii . zj
- Re: [PATCH][sh] Fix iov[] size in register_dump()
  - From: Kaz Kojima
- Re: [PATCH][sh] Fix iov[] size in register_dump()
  - From: takashi . yoshii . zj

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]