This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Use CPUID_OFFSET instead of FEATURE_OFFSET
- From: "H.J. Lu" <hongjiu dot lu at intel dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 16 Feb 2010 10:32:54 -0800
- Subject: Re: PATCH: Use CPUID_OFFSET instead of FEATURE_OFFSET
- References: <20100216182811.GA31249@lucon.org>
- Reply-to: "H.J. Lu" <hjl dot tools at gmail dot com>
On Tue, Feb 16, 2010 at 10:28:11AM -0800, H.J. Lu wrote:
> Hi,
>
> This patch fixes a typo.
>
> H.J.
> ---
> 2010-02-16 H.J. Lu <hongjiu.lu@intel.com>
>
> * sysdeps/i386/i686/multiarch/memcmp.S (memcmp): Use CPUID_OFFSET
> instead of FEATURE_OFFSET.
> * sysdeps/i386/i686/multiarch/strcmp.S (strcmp):
It should be
* sysdeps/i386/i686/multiarch/strcmp.S (strcmp): Likewise.
H.J.
--
>
> diff --git a/sysdeps/i386/i686/multiarch/memcmp.S b/sysdeps/i386/i686/multiarch/memcmp.S
> index fa7c52a..cf606a5 100644
> --- a/sysdeps/i386/i686/multiarch/memcmp.S
> +++ b/sysdeps/i386/i686/multiarch/memcmp.S
> @@ -58,7 +58,7 @@ ENTRY(memcmp)
> testl $bit_SSSE3, CPUID_OFFSET+index_SSSE3+__cpu_features
> jz 2f
> leal __memcmp_ssse3, %eax
> - testl $bit_SSE4_2, FEATURE_OFFSET+index_SSE4_2+__cpu_features
> + testl $bit_SSE4_2, CPUID_OFFSET+index_SSE4_2+__cpu_features
> jz 2f
> leal __memcmp_sse4_2, %eax
> 2: ret
> diff --git a/sysdeps/i386/i686/multiarch/strcmp.S b/sysdeps/i386/i686/multiarch/strcmp.S
> index 79a1fdf..7136d47 100644
> --- a/sysdeps/i386/i686/multiarch/strcmp.S
> +++ b/sysdeps/i386/i686/multiarch/strcmp.S
> @@ -83,7 +83,7 @@ ENTRY(STRCMP)
> testl $bit_SSSE3, CPUID_OFFSET+index_SSSE3+__cpu_features
> jz 2f
> leal __STRCMP_SSSE3, %eax
> - testl $bit_SSE4_2, FEATURE_OFFSET+index_SSE4_2+__cpu_features
> + testl $bit_SSE4_2, CPUID_OFFSET+index_SSE4_2+__cpu_features
> jz 2f
> leal __STRCMP_SSE4_2, %eax
> 2: ret