Re: [PATCH] S/390: HW accelerated iconv module for iso-8859-1/cp37conversions

[Ulrich Drepper <drepper at redhat dot com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andreas Krebbel wrote:
> Trying to build the iconv module from the s390 sysdep directory turned
> out to be rather tricky (at least for me not being familiar with the
> libc build machinery).

You should be able to just have an iso8859-1.c file in a s390-specific
directory.  You don't need to original module and therefore there is no
need for the original module.

If there is an issue with using the module on machines which don't have
this instruction then we can slightly extend the loop.c implementation.
 Add a second BODY definition (BODY2) and a new macro BODY_SELECT or so
to select which of the two to select.  Then in loop.c, if BODY_SELECT is
defined, replicate the while loop around BODY for BODY2.


Also, isn't ISO 8859-1 outdated?  Almost nobody in Europe can use it
because of the missing â sign.  You should rather support ISO 8859-15 etc.

- --
â Ulrich Drepper â Red Hat, Inc. â 444 Castro St â Mountain View, CA â
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkmr4iAACgkQ2ijCOnn/RHRo4gCgrFra6xKl40BhbztyoS/qFD1x
k6YAnAzD3WpV2rCG5z5FSZ5DmwufsAM3
=BtVK
-----END PGP SIGNATURE-----