This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] #undef __GLIBC__
On Tue, Nov 15, 2005 at 10:56:03AM +0100, Jakub Jelinek wrote:
> On Tue, Nov 15, 2005 at 10:44:37AM +0100, Robert Millan wrote:
> > On GNU/kFreeBSD, __GLIBC__ is a pre-processor macro. This patch fixes
> > features.h to #undef it before re-defining it to its proper value.
> >
> > 2005-11-15 Robert Millan <robertmh@gnu.org>
> >
> > * include/features.h: #undef __GLIBC__ before #define.
>
> That's IMNSHO the wrong fix. You should change GCC, so that it doesn't
> define __GLIBC__ as a preprocessor macro
We added this to GCC on purpose, because otherwise there's no way to identify
Glibc.
> and rather use some
> GCC/kFreeBSD specific macro instead.
That would imply a miss-conception on what an hybrid system means. If we add
this macro, people will start to use it in wrong ways. A porter who understands
the situation would notice that Glibc and kFreeBSD are orthogonal, and check for
them separately (this is not speculation: we have already used this scheme to
port hundreds of programs to GNU/kFreeBSD).
Thanks for considering,
--
Robert Millan