This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add sparc64 tls and nptl support


On Wed, Apr 13, 2005 at 03:58:14PM -0700, David S. Miller wrote:
> Are you saying that it doesn't matter that this macro is defined
> correctly in the two cases?  It seems that your include guarding
> patch only allows it to get set the first time, so it will only
> take on that first definition, is that what we want?

Inside !dl_machine_h protected part of the header is where many other
arches define this macro.
But looking at it closer, it seems we don't need the 2 definitions
on any architecture, just the one that handles also the TLS types.
That's what is actually always used in the current setup, since
the only file that defines RTLD_BOOTSTRAP is rtld.c and there
dl-machine.h is first included without that definition.
elf_machine_type_class is only used in dl-reloc.c though in
its RESOLVE_MAP macro, rtld.c's RESOLVE_MAP doesn't use that
and is much simpler.
So perhaps we can clean this up on all arches (but that can be done
in a separate patch).

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]