This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [BZ #382] Don't sort cflags in Makeconfig.


GOTO Masanori <gotom@debian.or.jp> writes:

> This patch is attached at BZ/382 (attachment/192) by 
> <nemethe+com.redhat.bugzilla@niif.hu>
>
> It claims if user specifies "-O2 --param max-reload-search-insns=200"
> for CFLAGS environment variable in configure time, then gcc in build
> time is failed to compile because Makeconfig sorts the following
> order: "--param -O2 max-reload-search-insns=200".  I confirmed it.
>
> Looking at that part:
>
> 	# Don't duplicate options if we inherited variables from the parent.
> 	+cflags	:= $(sort $(+cflags))
>
> But sort does not work as comments said.  I think this patch is OK
> rather than the current Makeconfig.

Doesn't this cause options to pile up?

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]