This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[BZ #382] Don't sort cflags in Makeconfig.


This patch is attached at BZ/382 (attachment/192) by 
<nemethe+com.redhat.bugzilla@niif.hu>

It claims if user specifies "-O2 --param max-reload-search-insns=200"
for CFLAGS environment variable in configure time, then gcc in build
time is failed to compile because Makeconfig sorts the following
order: "--param -O2 max-reload-search-insns=200".  I confirmed it.

Looking at that part:

	# Don't duplicate options if we inherited variables from the parent.
	+cflags	:= $(sort $(+cflags))

But sort does not work as comments said.  I think this patch is OK
rather than the current Makeconfig.

Regards,
-- gotom

2004-09-27  GOTO Masanori  <gotom@debian.or.jp>

	[BZ #382]
	* Makeconfig: Don't sort cflags.
	Patch by <nemethe+com.redhat.bugzilla@niif.hu>

Index: Makeconfig
===================================================================
RCS file: /cvs/glibc/libc/Makeconfig,v
retrieving revision 1.297
diff -u -r1.297 Makeconfig
--- Makeconfig	5 Aug 2004 03:34:28 -0000	1.297
+++ Makeconfig	27 Sep 2004 12:10:27 -0000
@@ -637,9 +637,6 @@
 +cflags := $(+cflags) $(+gccwarn)
 +gcc-nowarn := -w
 
-# Don't duplicate options if we inherited variables from the parent.
-+cflags	:= $(sort $(+cflags))
-
 
 # These are flags given to the C compiler to tell it to look for include
 # files (including ones given in angle brackets) in the current directory,
	


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]