This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: Fix alpha compilation failure
- From: Ulrich Drepper <drepper at redhat dot com>
- To: GOTO Masanori <gotom at debian dot or dot jp>
- Cc: Richard Henderson <rth at twiddle dot net>, libc-alpha at sources dot redhat dot com
- Date: Mon, 17 May 2004 10:58:41 -0700
- Subject: Re: Fix alpha compilation failure
- Organization: Red Hat, Inc.
- References: <81vfj1zk9o.wl@omega.webmasters.gr.jp>
GOTO Masanori wrote:
> The current cvs failed to compile on alpha with linux kernel < 2.6.4,
> because old version did not have __NR_{fstat,lstat,stat}64. This
> patch checks such syscalls are actually defined.
This patch is not correct. The code should never set errno unless it's
necessary. It's allowed by the standard, yes, but we still don't do it.
Secondly, it would be good to introduce an appropriate __ASSUME_* macro.
I know, this is nothing you introduced but still, it needs fixing.
--
â Ulrich Drepper â Red Hat, Inc. â 444 Castro St â Mountain View, CA â