This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: [PATCH] Correct formatting of internatinal currency (third try)
- From: Petter Reinholdtsen <pere at hungry dot com>
- To: libc-alpha at sources dot redhat dot com
- Date: Fri, 5 Dec 2003 14:04:16 +0100
- Subject: Re: [PATCH] Correct formatting of internatinal currency (third try)
- Bcc: Petter Reinholdtsen <petter dot reinholdtsen at usit dot uio dot no>
- References: <E19ybB3-0000xj-00@minerva.hungry.com> <3F64D140.2050102@redhat.com> <2flfzgfwi7r.fsf_-_@saruman.uio.no> <3FC4566A.8030706@redhat.com> <2flsmk5sob9.fsf@saruman.uio.no> <3FD0551A.1040705@redhat.com>
[Ulrich Drepper]
> I've applied the patches now, but with some changes. strfmon cannot use
> a static variable. The code must be thread safe.
Ah, good point.
> There is also no need to create yet more locales. Instead the int_*
> locale content should simply go in the already existing files.
Actually, there is a reason to create new test locales. One want to
detect when the domestic values are used instead of the international
values. I did this by making sure the int_ locales used the default
(ie C/POSIX locale) domestic values, and only changed the
international values. For this to work, strfmon() have to use the
international values. The error in strfmon() would not have been
detected with the test files in the current CVS. It would have been
detected with my suggested test set.
> The seems OK. Thanks,
Thank you too for your good job as the glibc gatekeeper. :)