This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: Regex fixes (latest CVS this time)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Paolo Bonzini <bonzini at gnu dot org>
- Cc: libc-alpha at sources dot redhat dot com, isamu at yamato dot ibm dot com
- Date: Sat, 20 Sep 2003 20:51:50 +0200
- Subject: Re: Regex fixes (latest CVS this time)
- References: <004c01c37f80$6aa0f260$9213623e@philo>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Sat, Sep 20, 2003 at 04:02:50PM +0200, Paolo Bonzini wrote:
> I downloaded the latest CVS; it fixes one of the XFAILs in sed; five remain,
> I'll send details soon.
>
> I found a possible out of bounds left shift. The first of these two patches
> fixes it, together with a bug in which \(^ was wrongly parsed as an anchor.
> Doing lookbehind in this case is wrong, instead it is ok for treating ^ as
> special if coming after a new-line character, and lookahead is ok for
> checking if $ is special. You should pass state down from the parser: I
> used the syntax bits for this, it may not be nice but it is simple and does
> not waste an entire parameter.
Can you please also include tests for the bugs for glibc testsuite?
(if they can be added just as another subtest for bug-regex{11,12}.c, then
that way, otherwise new tests).
Jakub