This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: stat.h with nanosecond resolution
- From: Andreas Jaeger <aj at suse dot de>
- To: "Martin Schwidefsky" <schwidefsky at de dot ibm dot com>
- Cc: libc-alpha at sources dot redhat dot com, Andi Kleen <ak at suse dot de>
- Date: Fri, 10 Jan 2003 15:30:48 +0100
- Subject: Re: stat.h with nanosecond resolution
- References: <OF06B0E17F.FF4A9281-ONC1256CAA.004398E7@de.ibm.com>
"Martin Schwidefsky" <schwidefsky@de.ibm.com> writes:
> Hi Andreas,
>> - s390x: The s390-64/kernel_stat.h file differed from the one in Linux
>> 2.5. I've merged in the 2.5 version now (it has the same layout as
>> the 2.4 version). Martin, please double check that this change is
>> correct, I don't see how it could have worked before.
>
> You are correct, the kernel_stat definition for s390x is broken. It does
> work despite it because the structure isn't used anywhere in glibc for
> s390x. It tested this by removing kernel_stat.h and a make, make check
> of todays libc snapshot. Your corrected version isn't perfect either,
> st_dev, st_ino, st_rdev are "unsigned long" not "unsigned int" and
> st_nlink/st_mode have swapped places. Two choices: remove kernel_stat.h
> or fix it a second time. I would remove the file. Whats your preference?
If it's not needed, let's remove it.
Andreas
--
Andreas Jaeger
SuSE Labs aj@suse.de
private aj@arthur.inka.de
http://www.suse.de/~aj