Re: [PATCH] Prepare PPC pread/pwrite for linux-2.5 headers

[Franz Sirl <Franz dot Sirl-kernel at lauterbach dot com>]

On Monday 04 November 2002 13:32, Jakub Jelinek wrote:
> On Mon, Nov 04, 2002 at 01:29:13PM +0100, Franz Sirl wrote:
> > --- sysdeps/unix/sysv/linux/powerpc/pwrite.c	6 Jul 2001 04:56:19
> > -0000	1.5 +++ sysdeps/unix/sysv/linux/powerpc/pwrite.c	27 Oct 2002
> > 13:53:29 -0000 @@ -23,6 +23,13 @@
> >  #include <sysdep.h>
> >  #include <sys/syscall.h>
> >
> > +#ifdef __NR_pwrite64            /* Newer kernels renamed but it's the
> > same.  */ +# ifdef __NR_pwrite
> > +#  error "__NR_pwrite and __NR_pwrite64 both defined???"
> > +# endif
> > +# define __NR_pwrite __NR_pread64
>
> 			      ^^^^Typo.
>
> > +#endif
> > +
> >  #ifdef __NR_pwrite
> >
> >  extern ssize_t __syscall_pwrite (int fd, const void *buf, size_t count,
> > --- sysdeps/unix/sysv/linux/powerpc/pwrite64.c	3 Aug 2002 06:57:52
> > -0000	1.7 +++ sysdeps/unix/sysv/linux/powerpc/pwrite64.c	27 Oct 2002
> > 13:53:30 -0000 @@ -23,6 +23,13 @@
> >  #include <sysdep.h>
> >  #include <sys/syscall.h>
> >
> > +#ifdef __NR_pwrite64            /* Newer kernels renamed but it's the
> > same.  */ +# ifdef __NR_pwrite
> > +#  error "__NR_pwrite and __NR_pwrite64 both defined???"
> > +# endif
> > +# define __NR_pwrite __NR_pread64
>
> 			      ^^^^Likewise.

Hehe, all I can say is that it's not really my fault, I copy'n'pasted it from 
the generic ones :-).

Attached a fixed patch, fixing up the generic versions as well.

Franz.

	* sysdeps/unix/sysv/linux/pwrite.c: Fix typo.
	* sysdeps/unix/sysv/linux/pwrite64.c: Likewise.
	* sysdeps/unix/sysv/linux/powerpc/pread.c: Handle both __NR_pread64
	and __NR_pread.
	* sysdeps/unix/sysv/linux/powerpc/pread64.c: Likewise.
	* sysdeps/unix/sysv/linux/powerpc/pwrite.c: Handle both __NR_pwrite64
	and __NR_pwrite.
	* sysdeps/unix/sysv/linux/powerpc/pwrite64.c: Likewise.

Attachment: glibc-pread-pwrite-2.patch
Description: Text document