This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: [PATCH] PowerPC64 port part 5 of 7
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Andreas Jaeger wrote:
Do we want this consistency? I don't see why it's needed.
If the symbol is not exported there is nothing to do.
2002-02-20 Steven Munroe <sjmunroe@us.ibm.com>
* catgets/Makefile: Condition tests on $(build-shared)
* iconv/Makefile: Condition tests on $(build-shared)
* iconvdata/Makefile: Condition tests on $(build-shared)
* libio/Makefile: Condition tests on $(build-shared)
* localedata/Makefile: Condition tests on $(build-shared)
* posix/Makefile: Condition tests on $(build-shared)
* rt/Makefile: Condition tests on $(build-shared)
* stdio-common/Makefile: Condition tests on $(build-shared)
* time/Makefile: Condition tests on $(build-shared)
* wcsmbs/Makefile: Condition tests on $(build-shared)
Allow glibc configured with --disable-shared and before shared
libraries are working, to run make check.
This looks fine to me.
This is adding tons of duplication. Just add a separate "tests:" goal
for the tests which need DSOs.
Before committing I would clean up the patch (remove whitespace, fix
comments).
It's not you who hasn't followed the rules...
- --
- ---------------. ,-. 1325 Chesapeake Terrace
Ulrich Drepper \ ,-------------------' \ Sunnyvale, CA 94089 USA
Red Hat `--' drepper at redhat.com `------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQE9YfQc2ijCOnn/RHQRAu+nAKCIJOTRL+bqgyKCnyOixxJSMxR2AACfXRvX
uV34Bt3ZwN7M4uhYlU+E99I=
=nziP
-----END PGP SIGNATURE-----