Re: gregset vs prgregset vs elf_gregset in thread_db

[Daniel Jacobowitz <drow at mvista dot com>]

On Tue, Jun 26, 2001 at 10:53:23PM -0700, Daniel Jacobowitz wrote:
> On Tue, Jun 26, 2001 at 09:59:32AM -0700, Geoff Keating wrote:
> > > Date: Mon, 25 Jun 2001 22:15:37 -0700
> > > From: Daniel Jacobowitz <dmj+@andrew.cmu.edu>
> > 
> > > On Mon, Jun 25, 2001 at 10:25:48PM -0700, Geoff Keating wrote:
> > > > I don't believe anything other than gdb uses these structures.  They
> > > > don't reflect anything that the kernel produces, do they?
> > > 
> > > That's right.  They're solely an interface for debuggers, and I do not
> > > know of any Linux debugger other than gdb which uses them, so I figure
> > > changing them to be more convenient to gdb would be a reasonable thing.
> > 
> > That's what I'd thought.  In that case, they can be changed in any way
> > that gdb finds convenient.
> 
> In that case, is this patch OK?
> 
> 2001-06-26  Daniel Jacobowitz  <dan@debian.org>
> 	* sysdeps/unix/sysv/linux/alpha/sys/procfs.h: Change prgregset_t
> 	and prfpregset_t to match their elf counterparts.
> 	* sysdeps/unix/sysv/linux/ia64/sys/procfs.h: Likewise.
> 	* sysdeps/unix/sysv/linux/mips/sys/procfs.h: Likewise.
> 	* sysdeps/unix/sysv/linux/sys/procfs.h: Likewise.

Ping!
I posted this patch three months ago and no one objected; could it
please be applied?

> Index: sysdeps/unix/sysv/linux/alpha/sys/procfs.h
> ===================================================================
> RCS file: /cvs/glibc/libc/sysdeps/unix/sysv/linux/alpha/sys/procfs.h,v
> retrieving revision 1.7
> diff -u -r1.7 procfs.h
> --- procfs.h	1999/11/18 00:11:49	1.7
> +++ procfs.h	2001/06/27 05:48:39
> @@ -99,8 +99,8 @@
>  typedef void *psaddr_t;
>  
>  /* Register sets.  Linux has different names.  */
> -typedef gregset_t prgregset_t;
> -typedef fpregset_t prfpregset_t;
> +typedef elf_gregset_t prgregset_t;
> +typedef elf_fpregset_t prfpregset_t;
>  
>  /* We don't have any differences between processes and threads,
>     therefore habe only ine PID type.  */
> Index: sysdeps/unix/sysv/linux/ia64/sys/procfs.h
> ===================================================================
> RCS file: /cvs/glibc/libc/sysdeps/unix/sysv/linux/ia64/sys/procfs.h,v
> retrieving revision 1.1
> diff -u -r1.1 procfs.h
> --- procfs.h	2000/06/20 03:34:47	1.1
> +++ procfs.h	2001/06/27 05:48:40
> @@ -104,8 +104,8 @@
>  typedef void *psaddr_t;
>  
>  /* Register sets.  Linux has different names.  */
> -typedef gregset_t prgregset_t;
> -typedef fpregset_t prfpregset_t;
> +typedef elf_gregset_t prgregset_t;
> +typedef elf_fpregset_t prfpregset_t;
>  
>  /* We don't have any differences between processes and threads,
>     therefore habe only ine PID type.  */
> Index: sysdeps/unix/sysv/linux/mips/sys/procfs.h
> ===================================================================
> RCS file: /cvs/glibc/libc/sysdeps/unix/sysv/linux/mips/sys/procfs.h,v
> retrieving revision 1.6
> diff -u -r1.6 procfs.h
> --- procfs.h	2000/01/10 14:27:50	1.6
> +++ procfs.h	2001/06/27 05:48:40
> @@ -101,8 +101,8 @@
>  typedef void *psaddr_t;
>  
>  /* Register sets.  Linux has different names.  */
> -typedef gregset_t prgregset_t;
> -typedef fpregset_t prfpregset_t;
> +typedef elf_gregset_t prgregset_t;
> +typedef elf_fpregset_t prfpregset_t;
>  
>  /* We don't have any differences between processes and threads,
>     therefore habe only ine PID type.  */
> Index: sysdeps/unix/sysv/linux/sys/procfs.h
> ===================================================================
> RCS file: /cvs/glibc/libc/sysdeps/unix/sysv/linux/sys/procfs.h,v
> retrieving revision 1.11
> diff -u -r1.11 procfs.h
> --- procfs.h	1999/11/15 07:59:41	1.11
> +++ procfs.h	2001/06/27 05:48:40
> @@ -99,8 +99,8 @@
>  typedef void *psaddr_t;
>  
>  /* Register sets.  Linux has different names.  */
> -typedef gregset_t prgregset_t;
> -typedef fpregset_t prfpregset_t;
> +typedef elf_gregset_t prgregset_t;
> +typedef elf_fpregset_t prfpregset_t;
>  
>  /* We don't have any differences between processes and threads,
>     therefore habe only ine PID type.  */
> 
> 
> -- 
> Daniel Jacobowitz                           Carnegie Mellon University
> MontaVista Software                         Debian GNU/Linux Developer
> 

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer