This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: iconv make check failures under ppc
On Sat, 09 Sep 2000, Geoff Keating wrote:
> > From: Franz Sirl <Franz.Sirl-kernel@lauterbach.com>
> > Date: Sat, 9 Sep 2000 23:02:20 +0200
> >
> > Anyway, the documentation clearly states that the explicit use of
> > volatile is the recommended practice, so I think we better change
> > it.
>
> This I agree with. Please commit that change.
Heh, I can post the patch here, but I have no checkin rights to glibc, just
gcc :-). You can acknowledge my last gcc patch for commit though, while you
are at it ;-)).
Franz.
* sysdeps/powerpc/dl-machine.c (PPC_DCBST): Add volatile.
(PPC_SYNC): Likewise.
(PPC_ICBI): Likewise.
Index: sysdeps/powerpc/dl-machine.c
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/powerpc/dl-machine.c,v
retrieving revision 1.11
diff -u -p -r1.11 dl-machine.c
--- sysdeps/powerpc/dl-machine.c 2000/06/12 07:13:21 1.11
+++ sysdeps/powerpc/dl-machine.c 2000/09/09 21:47:22
@@ -71,10 +71,10 @@
#define OPCODE_SLWI(ra,rs,sh) OPCODE_RLWINM(ra,rs,sh,0,31-sh)
-#define PPC_DCBST(where) asm ("dcbst 0,%0" : : "r"(where) : "memory")
-#define PPC_SYNC asm ("sync" : : : "memory")
+#define PPC_DCBST(where) asm volatile ("dcbst 0,%0" : : "r"(where) : "memory")
+#define PPC_SYNC asm volatile ("sync" : : : "memory")
#define PPC_ISYNC asm volatile ("sync; isync" : : : "memory")
-#define PPC_ICBI(where) asm ("icbi 0,%0" : : "r"(where) : "memory")
+#define PPC_ICBI(where) asm volatile ("icbi 0,%0" : : "r"(where) : "memory")
#define PPC_DIE asm volatile ("tweq 0,0")
/* Use this when you've modified some code, but it won't be in the