This is the mail archive of the
glibc-cvs@sourceware.org
mailing list for the glibc project.
[glibc/release/2.27/master] aarch64/strcmp: fix misaligned loop jump target
- From: Wilco Dijkstra <wilco at sourceware dot org>
- To: glibc-cvs at sourceware dot org
- Date: 6 Sep 2019 16:30:57 -0000
- Subject: [glibc/release/2.27/master] aarch64/strcmp: fix misaligned loop jump target
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=d5f45a29ff152a079f3ab6b3f9a8f8dce261252f
commit d5f45a29ff152a079f3ab6b3f9a8f8dce261252f
Author: Siddhesh Poyarekar <siddhesh@sourceware.org>
Date: Thu Feb 22 23:48:13 2018 +0530
aarch64/strcmp: fix misaligned loop jump target
I accidentally set the loop jump back label as misaligned8 instead of
do_misaligned. The typo is harmless but it's always nice to not have
to unnecessarily execute those two instructions.
* sysdeps/aarch64/strcmp.S (do_misaligned): Jump back to
do_misaligned, not misaligned8.
(cherry picked from commit 6ca24c43481e2c93a6eec362b04c3e77a35b28e3)
Diff:
---
ChangeLog | 5 +++++
sysdeps/aarch64/strcmp.S | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/ChangeLog b/ChangeLog
index 436aee2..5ddc3e7 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
2019-09-06 Siddhesh Poyarekar <siddhesh@sourceware.org>
+ * sysdeps/aarch64/strcmp.S (do_misaligned): Jump back to
+ do_misaligned, not misaligned8.
+
+2019-09-06 Siddhesh Poyarekar <siddhesh@sourceware.org>
+
* sysdeps/aarch64/strcmp.S (misaligned8): Compare dword at a
time whenever possible.
diff --git a/sysdeps/aarch64/strcmp.S b/sysdeps/aarch64/strcmp.S
index 0b22f16..267aa4b 100644
--- a/sysdeps/aarch64/strcmp.S
+++ b/sysdeps/aarch64/strcmp.S
@@ -158,7 +158,7 @@ L(do_misaligned):
ccmp data1w, data2w, #0, cs /* NZCV = 0b0000. */
b.ne L(done)
tst src1, #7
- b.ne L(misaligned8)
+ b.ne L(do_misaligned)
L(loop_misaligned):
/* Test if we are within the last dword of the end of a 4K page. If