This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

GNU C Library master sources branch master updated. glibc-2.26.9000-984-gf2da2fd

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  f2da2fd81f1d3f43678de9cf39b12692c6fa449b (commit)
      from  0c4fe28d7aaca041292d2db0a1a9ed4b64a7ddce (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------;a=commitdiff;h=f2da2fd81f1d3f43678de9cf39b12692c6fa449b

commit f2da2fd81f1d3f43678de9cf39b12692c6fa449b
Author: Joseph Myers <>
Date:   Fri Dec 15 14:27:20 2017 +0000

    Do not build .mo files in source directory (bug 14121).
    Building and installing glibc leaves .mo files (compiled message
    translations) behind in the source directory.  Building those files in
    the source directory may once have made sense, if they were included
    in release tarballs; now that release tarballs are just the output of
    "git archive", building any non-checked-in files in the source
    directory does not make sense.  This patch changes these files to be
    built in the build directory instead.  The realclean rule is changed
    to simply adding the .mo files to the "generated" variable, since once
    the files are in the build directory it make no sense to exclude them
    from normal cleanup rules.
    This is necessary but not sufficient to avoid
    needing to copy the glibc source directory.  Its list of files to
    touch on checkout to avoid subsequent regeneration (configure,
    preconfigure, *-kw.h) is incomplete (missing at least INSTALL,
    sysdeps/gnu/errlist.c, posix/testcases.h, posix/ptestcases.h,
    locale/C-translit.h, (only regenerated for Hurd builds)
    sysdeps/mach/hurd/bits/errno.h, (only regenerated for 32-bit SPARC
    builds) sysdeps/sparc/sparc32/{sdiv,udiv,rem,urem}.S) - the existing
    list may be sufficient to prevent regeneration that actually changes
    the file contents depending on the installed build tools, but not to
    ensure there is no regeneration at all - and there might well be other
    things writing into the source directory in the course of building and
    testing (so needing appropriate testing with read-only source
    directories with different timestamp orderings to find and eliminate
    all such cases).
    Tested for x86_64.
    	[BZ #14121]
    	* po/Makefile (generated): Add $(
    	( Change to $(objpfx)  Use $(make-target-directory).
    	($(mo-installed)): Use $(objpfx)
    	(realclean): Remove rule.

diff --git a/ChangeLog b/ChangeLog
index 83c4d07..35c258c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
 2017-12-15  Joseph Myers  <>
+	[BZ #14121]
+	* po/Makefile (generated): Add $(
+	( Change to $(objpfx)  Use $(make-target-directory).
+	($(mo-installed)): Use $(objpfx)
+	(realclean): Remove rule.
 	* po/Makefile (linguas): Remove rule and dependencies.
 	( Likewise.
 	(.PHONY): Do not depend on linguas and
diff --git a/po/Makefile b/po/Makefile
index 1fdce17..f811d33 100644
--- a/po/Makefile
+++ b/po/Makefile
@@ -44,6 +44,8 @@ mo-installed = $(inst_localedir)/%/LC_MESSAGES/$(domainname).mo
 # Files to install: a $(domainname).mo file for each language.
 install-others = $(LINGUAS:%=$(mo-installed))
+generated += $(
 include ../Rules
@@ -80,14 +82,12 @@ libc.pot.files: FORCE
 # Compile the binary message object files from the portable object source
 # files of translations for each language. %.po
+$(objpfx) %.po
+	$(make-target-directory)
 	$(MSGFMT) -o $@ $<
 # Install the message object files as libc.po in the language directory.
-$(mo-installed): $(+force); $(do-install) || exit 0
-	rm -f $(
+$(mo-installed): $(objpfx) $(+force); $(do-install) || exit 0
 # Update translations from the translation project.


Summary of changes:
 ChangeLog   |    6 ++++++
 po/Makefile |   10 +++++-----
 2 files changed, 11 insertions(+), 5 deletions(-)

GNU C Library master sources

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]