This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

GNU C Library master sources branch master updated. glibc-2.26.9000-596-g346729f

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  346729f66b905344e4ce24045489d189e5b4a9b8 (commit)
      from  508b1e71a37355839ab91f9c09ce7e577cf69a58 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------;a=commitdiff;h=346729f66b905344e4ce24045489d189e5b4a9b8

commit 346729f66b905344e4ce24045489d189e5b4a9b8
Author: Paul Clarke <>
Date:   Wed Oct 18 12:02:02 2017 -0200

    powerpc: fix check-before-set in SET_RESTORE_ROUND
    A performance regression was introduced by commit
    84d74e427a771906830800e574a72f8d25a954b8 "powerpc: Cleanup fenv_private.h".
    In the powerpc implementation of SET_RESTORE_ROUND, there is the
    following code in the "SET" function (slightly simplified):
      old.fenv = fegetenv_register ();
      new.l = (old.l & _FPU_MASK_TRAPS_RN) | r; (1)
      if (new.l != old.l)                       (2)
          if ((old.l & _FPU_ALL_TRAPS) != 0)
            (void) __fe_mask_env ();
          fesetenv_register (new.fenv);         (3)
    Line (1) sets the value of "new" to the current value of FPSCR,
    but masks off summary bits, exceptions, non-IEEE mode, and
    rounding mode, then ORs in the new rounding mode.
    Line (2) compares this new value to the current value in order to
    avoid setting a new value in the FPSCR (line (3)) unless something
    significant has changed (exception enables or rounding mode).
    The summary bits are not germane to the comparison, but are cleared
    in "new" and preserved in "old", resulting in false negative
    comparisons, and unnecessarily setting the FPSCR in those cases
    with associated negative performance impacts.
    The solution is to treat the summaries identically for "new" and "old":
    - save them in SET
    - leave them alone otherwise
    - restore the saved values in RESTORE
    Also minor changes:
    - expand _FPU_MASK_RN to 64bit hex, to match other MASKs
    - treat bit 52 (left-to-right) as reserved (since it is)
    	* sysdeps/powerpc/fpu/fenv_private.h (_FPU_MASK_TRAPS_RN):
    	(_FPU_MASK_FRAC_INEX_RET_CC): Fix masks to more properly handle
    	summary bits.
    	(_FPU_MASK_RN): Expand _FPU_MASK_RN to 64bit hex.
    	(_FPU_MASK_NOT_RN_NI): Treat bit 52 (left-to-right) as reserved.
    Reviewed-by: Tulio Magno Quites Machado Filho <>

diff --git a/ChangeLog b/ChangeLog
index 2ed8318..a344052 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2017-10-18  Paul A. Clarke  <>
+	* sysdeps/powerpc/fpu/fenv_private.h (_FPU_MASK_TRAPS_RN):
+	(_FPU_MASK_FRAC_INEX_RET_CC): Fix masks to more properly handle
+	summary bits.
+	(_FPU_MASK_RN): Expand _FPU_MASK_RN to 64bit hex.
+	(_FPU_MASK_NOT_RN_NI): Treat bit 52 (left-to-right) as reserved.
 2017-10-18  Mike FABIAN  <>
 	[BZ #16777]
diff --git a/sysdeps/powerpc/fpu/fenv_private.h b/sysdeps/powerpc/fpu/fenv_private.h
index 877f25b..984dff9 100644
--- a/sysdeps/powerpc/fpu/fenv_private.h
+++ b/sysdeps/powerpc/fpu/fenv_private.h
@@ -28,17 +28,16 @@
                       | _FPU_MASK_XM | _FPU_MASK_IM)
 /* Mask the rounding mode bits.  */
-#define _FPU_MASK_RN (~0x3)
+#define _FPU_MASK_RN 0xfffffffffffffffcLL
-/* Mask everything but the rounding moded and non-IEEE arithmetic flags.  */
-#define _FPU_MASK_NOT_RN_NI 0xffffffff00000007LL
+/* Mask everything but the rounding modes and non-IEEE arithmetic flags.  */
+#define _FPU_MASK_NOT_RN_NI 0xffffffff00000807LL
 /* Mask restore rounding mode and exception enabled.  */
-#define _FPU_MASK_TRAPS_RN 0xffffffff1fffff00LL
+#define _FPU_MASK_TRAPS_RN 0xffffffffffffff00LL
-/* Mask exception enable but fraction rounded/inexact and FP result/CC
-   bits.  */
-#define _FPU_MASK_FRAC_INEX_RET_CC 0xffffffff1ff80fff
+/* Mask FP result flags, preserve fraction rounded/inexact bits.  */
+#define _FPU_MASK_FRAC_INEX_RET_CC 0xfffffffffff80fffLL
 static __always_inline void
 __libc_feholdbits_ppc (fenv_t *envp, unsigned long long mask,


Summary of changes:
 ChangeLog                          |    8 ++++++++
 sysdeps/powerpc/fpu/fenv_private.h |   13 ++++++-------
 2 files changed, 14 insertions(+), 7 deletions(-)

GNU C Library master sources

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]