This is the mail archive of the glibc-cvs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

GNU C Library master sources branch gentoo/2.23 updated. glibc-2.23-12-g00479c7


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, gentoo/2.23 has been updated
       via  00479c708e155b2aaace94094b5cfaccdbd9e16e (commit)
       via  f571b1c53a6c4970969ef9fdb4aad2589d0b0427 (commit)
       via  ab0e0eeb92fcd1d5901051194a01f88d339f8e73 (commit)
      from  1053a4902ebff0ba30098fdcad614d963de87c3d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=00479c708e155b2aaace94094b5cfaccdbd9e16e

commit 00479c708e155b2aaace94094b5cfaccdbd9e16e
Author: Hongjiu Zhang <noctuorare@gmail.com>
Date:   Sun Mar 6 20:18:21 2016 -0500

    sln: use stat64
    
    When using sln on some filesystems which return 64-bit inodes,
    the stat call might fail during install like so:
    	.../elf/sln .../elf/symlink.list
    	/lib32/libc.so.6: invalid destination: Value too large for defined data type
    	/lib32/ld-linux.so.2: invalid destination: Value too large for defined data type
    	Makefile:104: recipe for target 'install-symbolic-link' failed
    
    Switch to using stat64 all the time to avoid this.
    
    URL: https://bugs.gentoo.org/576396
    (cherry picked from commit f5e753c8c3a18a1e3c715dd11bf4dc341b5c481f)
    (cherry picked from commit f23d7d2a8420a5ba2e28fc9c1d9c2b2996498d46)

diff --git a/elf/sln.c b/elf/sln.c
index 9d57be2..f52cb9f 100644
--- a/elf/sln.c
+++ b/elf/sln.c
@@ -164,11 +164,11 @@ makesymlinks (const char *file)
 static int
 makesymlink (const char *src, const char *dest)
 {
-  struct stat stats;
+  struct stat64 stats;
   const char *error;
 
   /* Destination must not be a directory. */
-  if (lstat (dest, &stats) == 0)
+  if (lstat64 (dest, &stats) == 0)
     {
       if (S_ISDIR (stats.st_mode))
 	{

http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=f571b1c53a6c4970969ef9fdb4aad2589d0b0427

commit f571b1c53a6c4970969ef9fdb4aad2589d0b0427
Author: Andreas Schwab <schwab@suse.de>
Date:   Tue Feb 23 16:27:56 2016 +0100

    Don't use long double math functions if NO_LONG_DOUBLE
    
    (cherry picked from commit 591b7e37e6be2a2d6672b683ba1191095b10d6d5)

diff --git a/math/test-math-isinff.cc b/math/test-math-isinff.cc
index 195d753..ecff1dc 100644
--- a/math/test-math-isinff.cc
+++ b/math/test-math-isinff.cc
@@ -30,12 +30,17 @@ do_test (void)
      header fix this test will not compile.  */
   if (isinff (1.0f)
       || !isinff (INFINITY)
+#ifndef NO_LONG_DOUBLE
       || isinfl (1.0L)
       || !isinfl (INFINITY)
+#endif
       || isnanf (2.0f)
       || !isnanf (NAN)
+#ifndef NO_LONG_DOUBLE
       || isnanl (2.0L)
-      || !isnanl (NAN))
+      || !isnanl (NAN)
+#endif
+      )
     {
       printf ("FAIL: Failed to call is* functions.\n");
       exit (1);

http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=ab0e0eeb92fcd1d5901051194a01f88d339f8e73

commit ab0e0eeb92fcd1d5901051194a01f88d339f8e73
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Mon Feb 22 09:32:57 2016 -0800

    [x86_64] Set DL_RUNTIME_UNALIGNED_VEC_SIZE to 8
    
    Due to GCC bug:
    
       https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58066
    
    __tls_get_addr may be called with 8-byte stack alignment.  Although
    this bug has been fixed in GCC 4.9.4, 5.3 and 6, we can't assume
    that stack will be always aligned at 16 bytes.  Since SSE optimized
    memory/string functions with aligned SSE register load and store are
    used in the dynamic linker, we must set DL_RUNTIME_UNALIGNED_VEC_SIZE
    to 8 so that _dl_runtime_resolve_sse will align the stack before
    calling _dl_fixup:
    
    Dump of assembler code for function _dl_runtime_resolve_sse:
       0x00007ffff7deea90 <+0>:	push   %rbx
       0x00007ffff7deea91 <+1>:	mov    %rsp,%rbx
       0x00007ffff7deea94 <+4>:	and    $0xfffffffffffffff0,%rsp
                                    ^^^^^^^^^^^ Align stack to 16 bytes
       0x00007ffff7deea98 <+8>:	sub    $0x100,%rsp
       0x00007ffff7deea9f <+15>:	mov    %rax,0xc0(%rsp)
       0x00007ffff7deeaa7 <+23>:	mov    %rcx,0xc8(%rsp)
       0x00007ffff7deeaaf <+31>:	mov    %rdx,0xd0(%rsp)
       0x00007ffff7deeab7 <+39>:	mov    %rsi,0xd8(%rsp)
       0x00007ffff7deeabf <+47>:	mov    %rdi,0xe0(%rsp)
       0x00007ffff7deeac7 <+55>:	mov    %r8,0xe8(%rsp)
       0x00007ffff7deeacf <+63>:	mov    %r9,0xf0(%rsp)
       0x00007ffff7deead7 <+71>:	movaps %xmm0,(%rsp)
       0x00007ffff7deeadb <+75>:	movaps %xmm1,0x10(%rsp)
       0x00007ffff7deeae0 <+80>:	movaps %xmm2,0x20(%rsp)
       0x00007ffff7deeae5 <+85>:	movaps %xmm3,0x30(%rsp)
       0x00007ffff7deeaea <+90>:	movaps %xmm4,0x40(%rsp)
       0x00007ffff7deeaef <+95>:	movaps %xmm5,0x50(%rsp)
       0x00007ffff7deeaf4 <+100>:	movaps %xmm6,0x60(%rsp)
       0x00007ffff7deeaf9 <+105>:	movaps %xmm7,0x70(%rsp)
    
    	[BZ #19679]
    	* sysdeps/x86_64/dl-trampoline.S (DL_RUNIME_UNALIGNED_VEC_SIZE):
    	Renamed to ...
    	(DL_RUNTIME_UNALIGNED_VEC_SIZE): This.  Set to 8.
    	(DL_RUNIME_RESOLVE_REALIGN_STACK): Renamed to ...
    	(DL_RUNTIME_RESOLVE_REALIGN_STACK): This.  Updated.
    	(DL_RUNIME_RESOLVE_REALIGN_STACK): Renamed to ...
    	(DL_RUNTIME_RESOLVE_REALIGN_STACK): This.
    	* sysdeps/x86_64/dl-trampoline.h
    	(DL_RUNIME_RESOLVE_REALIGN_STACK): Renamed to ...
    	(DL_RUNTIME_RESOLVE_REALIGN_STACK): This.
    
    (cherry picked from commit 6094fc2cf7eab30889df0416a5c051a5e7171895)

diff --git a/sysdeps/x86_64/dl-trampoline.S b/sysdeps/x86_64/dl-trampoline.S
index 9fb6b13..39b8771 100644
--- a/sysdeps/x86_64/dl-trampoline.S
+++ b/sysdeps/x86_64/dl-trampoline.S
@@ -33,15 +33,19 @@
 # define DL_STACK_ALIGNMENT 8
 #endif
 
-#ifndef DL_RUNIME_UNALIGNED_VEC_SIZE
-/* The maximum size of unaligned vector load and store.  */
-# define DL_RUNIME_UNALIGNED_VEC_SIZE 16
+#ifndef DL_RUNTIME_UNALIGNED_VEC_SIZE
+/* The maximum size in bytes of unaligned vector load and store in the
+   dynamic linker.  Since SSE optimized memory/string functions with
+   aligned SSE register load and store are used in the dynamic linker,
+   we must set this to 8 so that _dl_runtime_resolve_sse will align the
+   stack before calling _dl_fixup.  */
+# define DL_RUNTIME_UNALIGNED_VEC_SIZE 8
 #endif
 
 /* True if _dl_runtime_resolve should align stack to VEC_SIZE bytes.  */
-#define DL_RUNIME_RESOLVE_REALIGN_STACK \
+#define DL_RUNTIME_RESOLVE_REALIGN_STACK \
   (VEC_SIZE > DL_STACK_ALIGNMENT \
-   && VEC_SIZE > DL_RUNIME_UNALIGNED_VEC_SIZE)
+   && VEC_SIZE > DL_RUNTIME_UNALIGNED_VEC_SIZE)
 
 /* Align vector register save area to 16 bytes.  */
 #define REGISTER_SAVE_VEC_OFF	0
@@ -76,7 +80,7 @@
 #ifdef HAVE_AVX512_ASM_SUPPORT
 # define VEC_SIZE		64
 # define VMOVA			vmovdqa64
-# if DL_RUNIME_RESOLVE_REALIGN_STACK || VEC_SIZE <= DL_STACK_ALIGNMENT
+# if DL_RUNTIME_RESOLVE_REALIGN_STACK || VEC_SIZE <= DL_STACK_ALIGNMENT
 #  define VMOV			vmovdqa64
 # else
 #  define VMOV			vmovdqu64
@@ -100,7 +104,7 @@ strong_alias (_dl_runtime_profile_avx, _dl_runtime_profile_avx512)
 
 #define VEC_SIZE		32
 #define VMOVA			vmovdqa
-#if DL_RUNIME_RESOLVE_REALIGN_STACK || VEC_SIZE <= DL_STACK_ALIGNMENT
+#if DL_RUNTIME_RESOLVE_REALIGN_STACK || VEC_SIZE <= DL_STACK_ALIGNMENT
 # define VMOV			vmovdqa
 #else
 # define VMOV			vmovdqu
@@ -119,7 +123,7 @@ strong_alias (_dl_runtime_profile_avx, _dl_runtime_profile_avx512)
 /* movaps/movups is 1-byte shorter.  */
 #define VEC_SIZE		16
 #define VMOVA			movaps
-#if DL_RUNIME_RESOLVE_REALIGN_STACK || VEC_SIZE <= DL_STACK_ALIGNMENT
+#if DL_RUNTIME_RESOLVE_REALIGN_STACK || VEC_SIZE <= DL_STACK_ALIGNMENT
 # define VMOV			movaps
 #else
 # define VMOV			movups
diff --git a/sysdeps/x86_64/dl-trampoline.h b/sysdeps/x86_64/dl-trampoline.h
index f419183..b90836a 100644
--- a/sysdeps/x86_64/dl-trampoline.h
+++ b/sysdeps/x86_64/dl-trampoline.h
@@ -30,7 +30,7 @@
 #undef REGISTER_SAVE_AREA
 #undef LOCAL_STORAGE_AREA
 #undef BASE
-#if DL_RUNIME_RESOLVE_REALIGN_STACK
+#if DL_RUNTIME_RESOLVE_REALIGN_STACK
 # define REGISTER_SAVE_AREA	(REGISTER_SAVE_AREA_RAW + 8)
 /* Local stack area before jumping to function address: RBX.  */
 # define LOCAL_STORAGE_AREA	8
@@ -57,7 +57,7 @@
 	cfi_startproc
 _dl_runtime_resolve:
 	cfi_adjust_cfa_offset(16) # Incorporate PLT
-#if DL_RUNIME_RESOLVE_REALIGN_STACK
+#if DL_RUNTIME_RESOLVE_REALIGN_STACK
 # if LOCAL_STORAGE_AREA != 8
 #  error LOCAL_STORAGE_AREA must be 8
 # endif
@@ -146,7 +146,7 @@ _dl_runtime_resolve:
 	VMOV (REGISTER_SAVE_VEC_OFF + VEC_SIZE * 5)(%rsp), %VEC(5)
 	VMOV (REGISTER_SAVE_VEC_OFF + VEC_SIZE * 6)(%rsp), %VEC(6)
 	VMOV (REGISTER_SAVE_VEC_OFF + VEC_SIZE * 7)(%rsp), %VEC(7)
-#if DL_RUNIME_RESOLVE_REALIGN_STACK
+#if DL_RUNTIME_RESOLVE_REALIGN_STACK
 	mov %RBX_LP, %RSP_LP
 	cfi_def_cfa_register(%rsp)
 	movq (%rsp), %rbx

-----------------------------------------------------------------------

Summary of changes:
 elf/sln.c                      |    4 ++--
 math/test-math-isinff.cc       |    7 ++++++-
 sysdeps/x86_64/dl-trampoline.S |   20 ++++++++++++--------
 sysdeps/x86_64/dl-trampoline.h |    6 +++---
 4 files changed, 23 insertions(+), 14 deletions(-)


hooks/post-receive
-- 
GNU C Library master sources


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]