This is the mail archive of the glibc-cvs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

GNU C Library master sources branch master updated. glibc-2.23-5-g1833769


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  1833769e19236119d6e41041a53e0f8047156c24 (commit)
      from  656ee792a998987c44f23636e864643887f0a916 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=1833769e19236119d6e41041a53e0f8047156c24

commit 1833769e19236119d6e41041a53e0f8047156c24
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Thu Feb 18 21:31:10 2016 +0000

    Fix ldbl-128ibm floorl for non-default rounding modes (bug 17899).
    
    The ldbl-128ibm implementation of floorl is only correct in
    round-to-nearest mode (in other modes, there are incorrect results and
    overflow exceptions in some cases going beyond the incorrect signs of
    zero results noted in bug 17899).  It is also unnecessarily
    complicated, rounding both high and low parts to the nearest integer
    and then adjusting for the semantics of floor, when it seems more
    natural to take the floor of the high part (__floor optimized inline
    versions can be used), and that of the low part if the high part is an
    integer.  This patch makes it use that simpler approach, with a
    canonicalization that works in all rounding modes (given that the only
    way the result can be noncanonical is if taking the floor of a
    negative noninteger low part increased its exponent).
    
    Tested for powerpc, where over a thousand failures are removed from
    test-ldouble.out (floorl problems affect many powl tests).
    
    	[BZ #17899]
    	* sysdeps/ieee754/ldbl-128ibm/math_ldbl.h (ldbl_canonicalize_int):
    	New function.
    	* sysdeps/ieee754/ldbl-128ibm/s_floorl.c (__floorl): Use __floor
    	on high and low parts then use ldbl_canonicalize_int if needed.

diff --git a/ChangeLog b/ChangeLog
index ffc8ea3..6f79779 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2016-02-18  Joseph Myers  <joseph@codesourcery.com>
+
+	[BZ #17899]
+	* sysdeps/ieee754/ldbl-128ibm/math_ldbl.h (ldbl_canonicalize_int):
+	New function.
+	* sysdeps/ieee754/ldbl-128ibm/s_floorl.c (__floorl): Use __floor
+	on high and low parts then use ldbl_canonicalize_int if needed.
+
 2016-02-18  Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 
 	* configure: Regenerated.
diff --git a/sysdeps/ieee754/ldbl-128ibm/math_ldbl.h b/sysdeps/ieee754/ldbl-128ibm/math_ldbl.h
index 051352f..625ce00 100644
--- a/sysdeps/ieee754/ldbl-128ibm/math_ldbl.h
+++ b/sysdeps/ieee754/ldbl-128ibm/math_ldbl.h
@@ -230,3 +230,36 @@ ldbl_nearbyint (double a)
     }
   return a;
 }
+
+/* Canonicalize a result from an integer rounding function, in any
+   rounding mode.  *A and *AA are finite and integers, with *A being
+   nonzero; if the result is not already canonical, *AA is plus or
+   minus a power of 2 that does not exceed the least set bit in
+   *A.  */
+static inline void
+ldbl_canonicalize_int (double *a, double *aa)
+{
+  int64_t ax, aax;
+  EXTRACT_WORDS64 (ax, *a);
+  EXTRACT_WORDS64 (aax, *aa);
+  int expdiff = ((ax >> 52) & 0x7ff) - ((aax >> 52) & 0x7ff);
+  if (expdiff <= 53)
+    {
+      if (expdiff == 53)
+	{
+	  /* Half way between two double values; noncanonical iff the
+	     low bit of A's mantissa is 1.  */
+	  if ((ax & 1) != 0)
+	    {
+	      *a += 2 * *aa;
+	      *aa = -*aa;
+	    }
+	}
+      else
+	{
+	  /* The sum can be represented in a single double.  */
+	  *a += *aa;
+	  *aa = 0;
+	}
+    }
+}
diff --git a/sysdeps/ieee754/ldbl-128ibm/s_floorl.c b/sysdeps/ieee754/ldbl-128ibm/s_floorl.c
index 9122308..a146964 100644
--- a/sysdeps/ieee754/ldbl-128ibm/s_floorl.c
+++ b/sysdeps/ieee754/ldbl-128ibm/s_floorl.c
@@ -35,35 +35,22 @@ __floorl (long double x)
 			&& __builtin_isless (__builtin_fabs (xh),
 					     __builtin_inf ()), 1))
     {
-      /* Long double arithmetic, including the canonicalisation below,
-	 only works in round-to-nearest mode.  */
-
-      /* Convert the high double to integer.  */
-      hi = ldbl_nearbyint (xh);
-
-      /* Subtract integral high part from the value.  */
-      xh -= hi;
-      ldbl_canonicalize (&xh, &xl);
-
-      /* Now convert the low double, adjusted for any remainder from the
-         high double.  */
-      lo = ldbl_nearbyint (xh);
-
-      /* Adjust the result when the remainder is non-zero.  nearbyint
-         rounds values to the nearest integer, and values halfway
-         between integers to the nearest even integer.  floorl must
-         round towards -Inf.  */
-      xh -= lo;
-      ldbl_canonicalize (&xh, &xl);
-
-      if (xh < 0.0 || (xh == 0.0 && xl < 0.0))
-	lo += -1.0;
-
-      /* Ensure the final value is canonical.  In certain cases,
-         rounding causes hi,lo calculated so far to be non-canonical.  */
-      xh = hi;
-      xl = lo;
-      ldbl_canonicalize (&xh, &xl);
+      hi = __floor (xh);
+      if (hi != xh)
+	{
+	  /* The high part is not an integer; the low part does not
+	     affect the result.  */
+	  xh = hi;
+	  xl = 0;
+	}
+      else
+	{
+	  /* The high part is a nonzero integer.  */
+	  lo = __floor (xl);
+	  xh = hi;
+	  xl = lo;
+	  ldbl_canonicalize_int (&xh, &xl);
+	}
     }
 
   return ldbl_pack (xh, xl);

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                               |    8 +++++
 sysdeps/ieee754/ldbl-128ibm/math_ldbl.h |   33 ++++++++++++++++++++++
 sysdeps/ieee754/ldbl-128ibm/s_floorl.c  |   45 +++++++++++--------------------
 3 files changed, 57 insertions(+), 29 deletions(-)


hooks/post-receive
-- 
GNU C Library master sources


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]