This is the mail archive of the
glibc-cvs@sourceware.org
mailing list for the glibc project.
GNU C Library master sources branch master updated. glibc-2.21-590-g0c8f39c
- From: siddhesh at sourceware dot org
- To: glibc-cvs at sourceware dot org
- Date: 10 Jul 2015 17:58:41 -0000
- Subject: GNU C Library master sources branch master updated. glibc-2.21-590-g0c8f39c
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".
The branch, master has been updated
via 0c8f39cbf769ef35f54b57859e1e87b5291daf5e (commit)
via 962a1aeb28ac38019034e89ae4e87e515f3d25bd (commit)
from 1aa8d144f971a907950014177d7e150fe82b83b0 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=0c8f39cbf769ef35f54b57859e1e87b5291daf5e
commit 0c8f39cbf769ef35f54b57859e1e87b5291daf5e
Author: Siddhesh Poyarekar <siddhesh@redhat.com>
Date: Fri Jul 10 23:23:57 2015 +0530
Remove unnecessary mutex locks from tst-tls-atexit test case
The locks don't synchronize with anything - they were likely
introduced initially to synchronize with some main thread code, but
that is no longer evident.
diff --git a/ChangeLog b/ChangeLog
index 8ee61d6..0c7fc2c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
2015-07-10 Siddhesh Poyarekar <siddhesh@redhat.com>
+ * stdlib/tst-tls-atexit.c (load): Remove unnecessary mutex
+ locks.
+
* stdlib/tst-tls-atexit.c (load): Avoid boolean coercion.
2015-07-10 Torvald Riegel <triegel@redhat.com>
diff --git a/stdlib/tst-tls-atexit.c b/stdlib/tst-tls-atexit.c
index 7a69722..5ee04a8 100644
--- a/stdlib/tst-tls-atexit.c
+++ b/stdlib/tst-tls-atexit.c
@@ -29,12 +29,10 @@
#include <errno.h>
void *handle;
-pthread_mutex_t m = PTHREAD_MUTEX_INITIALIZER;
void *
load (void *u)
{
- pthread_mutex_lock (&m);
handle = dlopen ("$ORIGIN/tst-tls-atexit-lib.so", RTLD_LAZY);
if (handle == NULL)
{
@@ -55,7 +53,6 @@ load (void *u)
/* This should not unload the DSO. If it does, then the thread exit will
result in a segfault. */
dlclose (handle);
- pthread_mutex_unlock (&m);
return NULL;
}
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=962a1aeb28ac38019034e89ae4e87e515f3d25bd
commit 962a1aeb28ac38019034e89ae4e87e515f3d25bd
Author: Siddhesh Poyarekar <siddhesh@redhat.com>
Date: Fri Jul 10 23:20:28 2015 +0530
Avoid boolean coercion in tst-tls-atexit test case
diff --git a/ChangeLog b/ChangeLog
index f4e4be6..8ee61d6 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2015-07-10 Siddhesh Poyarekar <siddhesh@redhat.com>
+
+ * stdlib/tst-tls-atexit.c (load): Avoid boolean coercion.
+
2015-07-10 Torvald Riegel <triegel@redhat.com>
* nptl/sem_waitcommon.c (__new_sem_wait_slow): Update comments.
diff --git a/stdlib/tst-tls-atexit.c b/stdlib/tst-tls-atexit.c
index 68247d1..7a69722 100644
--- a/stdlib/tst-tls-atexit.c
+++ b/stdlib/tst-tls-atexit.c
@@ -36,7 +36,7 @@ load (void *u)
{
pthread_mutex_lock (&m);
handle = dlopen ("$ORIGIN/tst-tls-atexit-lib.so", RTLD_LAZY);
- if (!handle)
+ if (handle == NULL)
{
printf ("Unable to load DSO: %s\n", dlerror ());
return (void *) (uintptr_t) 1;
@@ -44,7 +44,7 @@ load (void *u)
void (*foo) (void) = (void (*) (void)) dlsym(handle, "do_foo");
- if (!foo)
+ if (foo == NULL)
{
printf ("Unable to find symbol: %s\n", dlerror ());
exit (1);
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 7 +++++++
stdlib/tst-tls-atexit.c | 7 ++-----
2 files changed, 9 insertions(+), 5 deletions(-)
hooks/post-receive
--
GNU C Library master sources