This is the mail archive of the glibc-cvs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

GNU C Library master sources branch master updated. glibc-2.20-270-g9114625


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  9114625bad23441c89eac5a7dcf319a9714ca31f (commit)
      from  e7300fef49147a73d5dc7e0a462cc60aabb58400 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=9114625bad23441c89eac5a7dcf319a9714ca31f

commit 9114625bad23441c89eac5a7dcf319a9714ca31f
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Thu Nov 27 16:00:08 2014 +0000

    Fix dlfcn/failtestmod.c warning.
    
    This patch fixes a "set but not used" warning from
    dlfcn/failtestmod.c.  A variable is used only to store the return
    value from dlsym.  As I understand this test, the point is simply to
    do a sequence of load / unload operations in a loop, and all that
    matters here is that dlsym gets called and returns without crashing,
    not what its return value is.  So this patch removes the assignment to
    a variable.
    
    Tested for x86_64.
    
    	* dlfcn/failtestmod.c (constr): Do not store result of dlsym in a
    	variable.

diff --git a/ChangeLog b/ChangeLog
index 92ffe16..9090877 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2014-11-27  Joseph Myers  <joseph@codesourcery.com>
+
+	* dlfcn/failtestmod.c (constr): Do not store result of dlsym in a
+	variable.
+
 2014-11-27  Stefan Liebler  <stli@linux.vnet.ibm.com>
 
 	* nscd/connections.c: Include libc-internal.h because of macro
diff --git a/dlfcn/failtestmod.c b/dlfcn/failtestmod.c
index a03f90b..64dadd5 100644
--- a/dlfcn/failtestmod.c
+++ b/dlfcn/failtestmod.c
@@ -8,7 +8,6 @@ __attribute__ ((__constructor__))
 constr (void)
 {
   void *handle;
-  void *m;
 
   /* Open the library.  */
   handle = dlopen (NULL, RTLD_NOW);
@@ -19,7 +18,7 @@ constr (void)
     }
 
   /* Get a symbol.  */
-  m = dlsym (handle, "main");
+  dlsym (handle, "main");
   puts ("called dlsym() to get main");
 
   dlclose (handle);

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog           |    5 +++++
 dlfcn/failtestmod.c |    3 +--
 2 files changed, 6 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
GNU C Library master sources


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]