[Bug math/16068] [i386/x86_64] x86 and x86_64 fesetenv exclude state they should include

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=16068

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  77d08acaadfb197cd03c56ac8f72baabeb305f25 (commit)
      from  28162f4dac274a4b635d95fc2442bef888df1d57 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=77d08acaadfb197cd03c56ac8f72baabeb305f25

commit 77d08acaadfb197cd03c56ac8f72baabeb305f25
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Fri May 9 16:59:56 2014 +0000

    Include SSE state in i386 fenv_t (bug 16064).

    This patch fixes bug 16064, i386 fenv_t not including SSE state, using
    the technique suggested there of storing the state in the existing
    __eip field of fenv_t to avoid needing to increase the size of fenv_t
    and add new symbol versions.  The included testcase, which previously
    failed for i386 (but passed for x86_64), illustrates how the previous
    state was buggy.

    This patch causes the SSE state to be included *to the extent it is on
    x86_64*.  Where some state should logically be included but isn't for
    x86_64 (see bug 16068), this patch does not cause it to be included
    for i386 either.  The idea is that any patch fixing that bug should
    fix it for both x86_64 and i386 at once.

    Tested i386 and x86_64.  (I haven't tested the case of a CPU without
    SSE2 disabling the test.)

        [BZ #16064]
        * sysdeps/i386/fpu/fegetenv.c: Include <unistd.h>, <ldsodefs.h>
        and <dl-procinfo.h>.
        (__fegetenv): Save SSE state in envp->__eip if supported.
        * sysdeps/i386/fpu/feholdexcpt.c (feholdexcept): Save SSE state in
        envp->__eip if supported.
        * sysdeps/i386/fpu/fesetenv.c: Include <unistd.h>, <ldsodefs.h>
        and <dl-procinfo.h>.
        (__fesetenv): Always set __eip, __cs_selector, __opcode,
        __data_offset and __data_selector in environment to 0.  Set SSE
        state if supported.
        * sysdeps/x86/fpu/Makefile [$(subdir) = math] (tests): Add
        test-fenv-sse.
        [$(subdir) = math] (CFLAGS-test-fenv-sse.c): Add -msse2
        -mfpmath=sse.
        * sysdeps/x86/fpu/test-fenv-sse.c: New file.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                       |   19 +++++
 NEWS                            |    4 +-
 sysdeps/i386/fpu/fegetenv.c     |    6 ++
 sysdeps/i386/fpu/feholdexcpt.c  |    4 +-
 sysdeps/i386/fpu/fesetenv.c     |   50 ++++++++++----
 sysdeps/x86/fpu/Makefile        |    2 +
 sysdeps/x86/fpu/test-fenv-sse.c |  138 +++++++++++++++++++++++++++++++++++++++
 7 files changed, 204 insertions(+), 19 deletions(-)
 create mode 100644 sysdeps/x86/fpu/test-fenv-sse.c

-- 
You are receiving this mail because:
You are on the CC list for the bug.