This is the mail archive of the
glibc-bugs@sourceware.org
mailing list for the glibc project.
[Bug math/16677] nextafter incorrect in directed rounding modes
- From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>
- To: glibc-bugs at sourceware dot org
- Date: Tue, 11 Mar 2014 22:25:09 +0000
- Subject: [Bug math/16677] nextafter incorrect in directed rounding modes
- Auto-submitted: auto-generated
- References: <bug-16677-131 at http dot sourceware dot org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=16677
--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".
The branch, master has been updated
via 600fa36158cd741d897b2d22c735c60247b982e0 (commit)
from d7706c32589ef32f4bed3122a2f5c861b214149e (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=600fa36158cd741d897b2d22c735c60247b982e0
commit 600fa36158cd741d897b2d22c735c60247b982e0
Author: Joseph Myers <joseph@codesourcery.com>
Date: Tue Mar 11 22:24:00 2014 +0000
Fix nextafter overflow in non-default rounding modes (bug 16677).
ISO C requires the result of nextafter to be independent of the
rounding mode, even when underflow or overflow occurs. This patch
fixes the bug in various nextafter implementations that, having done
an overflowing computation to force an overflow exception (correct),
they then return the result of that computation rather than an
infinity computed some other way (incorrect, when the overflowing
result of arithmetic with that sign and rounding mode is finite but
the correct result is infinite) - generally by falling through to
existing code to return a value that in fact is correct for this case
(but was computed by an integer increment and so without generating
the exceptions required). Having fixed the bug, the previously
deferred conversion of nextafter testing in libm-test.inc to
ALL_RM_TEST is also included.
Tested x86_64 and x86; also spot-checked results of nextafter tests
for powerpc32 and mips64 to test the ldbl-128ibm and ldbl-128
changes. (The m68k change is untested.)
[BZ #16677]
* math/s_nextafter.c (__nextafter): Do not return value from
overflowing computation.
* sysdeps/i386/fpu/s_nextafterl.c (__nextafterl): Likewise.
* sysdeps/ieee754/flt-32/s_nextafterf.c (__nextafterf): Likewise.
* sysdeps/ieee754/ldbl-128/s_nextafterl.c (__nextafterl):
Likewise.
* sysdeps/ieee754/ldbl-128ibm/s_nextafterl.c (__nextafterl):
Likewise.
* sysdeps/m68k/m680x0/fpu/s_nextafterl.c (__nextafterl): Likewise.
* math/libm-test.inc (nextafter_test): Use ALL_RM_TEST.
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 14 ++++++++++++++
NEWS | 2 +-
math/libm-test.inc | 5 +----
math/s_nextafter.c | 6 ++----
sysdeps/i386/fpu/s_nextafterl.c | 5 ++++-
sysdeps/ieee754/flt-32/s_nextafterf.c | 6 ++----
sysdeps/ieee754/ldbl-128/s_nextafterl.c | 5 ++++-
sysdeps/ieee754/ldbl-128ibm/s_nextafterl.c | 14 ++++++++++----
sysdeps/m68k/m680x0/fpu/s_nextafterl.c | 5 ++++-
9 files changed, 42 insertions(+), 20 deletions(-)
--
You are receiving this mail because:
You are on the CC list for the bug.