This is the mail archive of the glibc-bugs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug libc/4040] sysdeps/i386/i486/bits/atomic.h has incorrect __asm constraints


------- Additional Comments From tom at tommay dot net  2007-02-15 21:34 -------
Thanks.  Were these changes intentionally omitted?

Index: sysdeps/i386/i486/bits/atomic.h
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/i386/i486/bits/atomic.h,v
retrieving revision 1.17
diff -u -r1.17 atomic.h
--- sysdeps/i386/i486/bits/atomic.h     15 Feb 2007 06:25:37 -0000      1.17
+++ sysdeps/i386/i486/bits/atomic.h     15 Feb 2007 18:27:04 -0000
@@ -507,7 +507,7 @@
                        : "=m" (*mem)                                         \
                        : "iq" (mask), "m" (*mem));                           \
     else if (sizeof (*mem) == 2)                                             \
-      __asm __volatile (LOCK_PREFIX "andw %1, %w0"                           \
+      __asm __volatile (LOCK_PREFIX "andw %w1, %0"                           \
                        : "=m" (*mem)                                         \
                        : "ir" (mask), "m" (*mem));                           \
     else if (sizeof (*mem) == 4)                                             \
@@ -527,7 +527,7 @@
                        : "iq" (mask), "m" (*mem),                            \
                          "i" (offsetof (tcbhead_t, multiple_threads)));      \
     else if (sizeof (*mem) == 2)                                             \
-      __asm __volatile (lock "orw %1, %w0"                                   \
+      __asm __volatile (lock "orw %w1, %0"                                   \
                        : "=m" (*mem)                                         \
                        : "ir" (mask), "m" (*mem),                            \
                          "i" (offsetof (tcbhead_t, multiple_threads)));      \


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://sourceware.org/bugzilla/show_bug.cgi?id=4040

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]