This is the mail archive of the glibc-bugs@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug regex/281] regex.c doesn't compile on hosts with signed char


------- Additional Comments From kasal at ucw dot cz  2004-07-23 14:45 -------
(In reply to comment #2)
> What kind of problems?
> Most of the arches have signed char.
> re_search_internal is certainly not the only place which uses
> unsigned RE_TRANSLATE_TYPE.

When the patch was created, exactly one year ago, this was the only place.
(I've submitted the patch to bug-glibc back then, but no answer...)

Since then, many bugs were fixed by adding "unsigned" before
RE_TRANSLATE_TYPE on many places.

> IMHO RE_TRANSLATE_TYPE should stay char *, it has been that way since the
> original GNU regex.

Well, my opinion has to be humble too, you have read more of regex then I.

But I think that it was a mistake originally, which is proved by the rapid
growth of "unsigned RE_TRANSLATE_TYPE" which you mentioned.

I don't see any problem with the change.

-- 


http://sources.redhat.com/bugzilla/show_bug.cgi?id=281

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]