This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
Re: [BABELTRACE PATCH] Namespace the lookup_enum function
- From: Mathieu Desnoyers <mathieu dot desnoyers at efficios dot com>
- To: Julien Desfossez <jdesfossez at efficios dot com>
- Cc: teawater at gmail dot com, lttng-dev at lists dot lttng dot org, gdb at sourceware dot org, tromey at redhat dot com, palves at redhat dot com
- Date: Sun, 13 Jan 2013 12:57:54 -0500
- Subject: Re: [BABELTRACE PATCH] Namespace the lookup_enum function
- References: <20130107211855.GB3678@Krystal> <1357760893-11961-1-git-send-email-jdesfossez@efficios.com>
* Julien Desfossez (jdesfossez@efficios.com) wrote:
> This patch namespaces the lookup_enum function because it causes problem
> with the integration in gdb even though it is not exported.
> Hui, can you try this patch and confirm it solves the current problem ?
> After that we will continue the internal namespacing.
Hi Julien,
Since we know these changes are needed, can you provide patches with
proper changelogs, and I'll pull them.
Thanks,
Mathieu
>
> Thanks,
>
> Julien
> ---
> formats/ctf/ctf.c | 2 +-
> include/babeltrace/types.h | 2 +-
> types/types.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/formats/ctf/ctf.c b/formats/ctf/ctf.c
> index 18a5601..a8f8408 100644
> --- a/formats/ctf/ctf.c
> +++ b/formats/ctf/ctf.c
> @@ -431,7 +431,7 @@ int ctf_read_event(struct stream_pos *ppos, struct ctf_stream_definition *stream
> } else {
> struct definition_enum *enum_definition;
>
> - enum_definition = lookup_enum(&stream->stream_event_header->p, "id", FALSE);
> + enum_definition = bt_lookup_enum(&stream->stream_event_header->p, "id", FALSE);
> if (enum_definition) {
> id = enum_definition->integer->value._unsigned;
> }
> diff --git a/include/babeltrace/types.h b/include/babeltrace/types.h
> index b42ba03..00c928b 100644
> --- a/include/babeltrace/types.h
> +++ b/include/babeltrace/types.h
> @@ -521,7 +521,7 @@ struct definition *lookup_definition(const struct definition *definition,
> struct definition_integer *lookup_integer(const struct definition *definition,
> const char *field_name,
> int signedness);
> -struct definition_enum *lookup_enum(const struct definition *definition,
> +struct definition_enum *bt_lookup_enum(const struct definition *definition,
> const char *field_name,
> int signedness);
> struct definition *lookup_variant(const struct definition *definition,
> diff --git a/types/types.c b/types/types.c
> index 5599027..139e318 100644
> --- a/types/types.c
> +++ b/types/types.c
> @@ -642,7 +642,7 @@ struct definition_integer *lookup_integer(const struct definition *definition,
> return lookup_integer;
> }
>
> -struct definition_enum *lookup_enum(const struct definition *definition,
> +struct definition_enum *bt_lookup_enum(const struct definition *definition,
> const char *field_name,
> int signedness)
> {
> --
> 1.7.10.4
>
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com