This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
Re: [patch gdb]: Fix some DOS-path related issues in gdb
2011/3/3 Mark Kettenis <mark.kettenis@xs4all.nl>:
>> Date: Thu, 3 Mar 2011 13:02:11 +0100
>> From: Kai Tietz <ktietz70@googlemail.com>
>>
>> Hello,
>>
>> This patch fixes some issues related to DOS file-system filenames and
>> paths. I am not sure, if I
>> hit all places, nevertheless I am sure I hit most.
>> This patch uses the libiberty functions & macros about
>> directory-separator checks, absolute-path checks,
>> and the filename-comparision functions.
>
> Please don't inflict the DOS-stupidity on stuff like bsd-kvm.c and
> fbsd-nat.c.
>
hmm, I admit that it is pretty unlikely that *nix-nat parts are used
with DOS-style paths. Nevertheless on cross-compiling from windows to
*nix such paths can happen easily. Additionally it is IMHO also an
issue of consistance in source. To use on one place
abstraction-routines and on other places not, is something weak and
causes sooner or later troubles.
Nevertheless if I get a constructive review for this patch, and
reviewer asks me to remove some portions of it I am open-minded to do
so.
Regards,
Kai