Re: cvs tracepoint.c build error

[Jan Kratochvil <jan dot kratochvil at redhat dot com>]

On Sat, 16 Jan 2010 19:53:38 +0100, Stan Shebs wrote:
> Oops, sorry!  In retrospect, size_t was a bad idea, this is our own
> code and we should use unsigned long long (large buffers with
> 32x64).  Fix forthcoming.

With -Wp,-D_FORTIFY_SOURCE=1 -O1 (Fedora 12) I get also:

tracepoint.c: In function ‘trace_save_command’:
tracepoint.c:2392: error: ignoring return value of ‘fwrite’, declared with attribute warn_unused_result
tracepoint.c:2476: error: ignoring return value of ‘fwrite’, declared with attribute warn_unused_result
tracepoint.c:2481: error: ignoring return value of ‘fwrite’, declared with attribute warn_unused_result
tracepoint.c: In function ‘tfile_open’:
tracepoint.c:2826: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c:2847: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c: In function ‘tfile_get_traceframe_address’:
tracepoint.c:3152: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c: In function ‘tfile_trace_find’:
tracepoint.c:3184: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c:3188: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c: In function ‘tfile_fetch_registers’:
tracepoint.c:3264: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c:3269: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c:3296: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c: In function ‘tfile_xfer_partial’:
tracepoint.c:3333: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c:3342: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c:3343: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c:3346: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c: In function ‘tfile_get_trace_state_variable_value’:
tracepoint.c:3380: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c:3390: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c:3395: error: ignoring return value of ‘read’, declared with attribute warn_unused_result
tracepoint.c:3398: error: ignoring return value of ‘read’, declared with attribute warn_unused_result

which IMO should be properly checked.


Thanks,
Jan