This is the mail archive of the gdb@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: GDB 6.8.92 available for testing

On 10/01/2009 11:40 AM, Andreas Schwab wrote:
"Pierre Muller"<muller@ics.u-strasbg.fr> writes:

Andreas,

why don't you simply use this?
#if RL_VERSION_MAJOR>= 6
   extern int _rl_echoing_p;
#define readline_echoing_p _rl_echoing_p
#else
    extern int readline_echoing_p;
#endif

This would make your patch simpler, no?

Is there a reason for replacing all
readline_echoing_p by _rl_echoing_p?


As explained in the mail, I want to emphasize that it is an internal
readline variable (as noticeable from the leading underscore).

Besides this, version checks are evil.

Ralf

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]