This is the mail archive of the gdb@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Queries and frontends


>>>>> "Nick" == Nick Roberts <nickrob@snap.net.nz> writes:

Tom> Since "server" is intended to hide commands from the user, why check
Tom> server_command at one particular query rather than in every query?

Nick> Because that would change existing behaviour.  It's probably a
Nick> small risk as no one else appears to be using the server prefix
Nick> or, if they are, they have kept a very low profile.  Just changing
Nick> "record stop" is sufficient for Emacs at the moment.  You could
Nick> say it's quick and nasty but I would call it pragmatic.

It seems to me that this is just a bug in the server prefix.  The intent
is to hide some actions from the user.  But, a query is definitely not
hidden.

My concern with the one-off is that it is unclear why the check is where
it is.  And the answer, when someone in the future looks it up, will be
"Emacs needed that".

I tend to think that the more generic change would be safe, and cleaner.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]