This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
答复: Re: [PATCH] Support new target S+core 3 , a variant of S+core
- From: 秦巍<qinwei at sunnorth dot com dot cn>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: don dot lee at sunplusct dot com, gdb at sourceware dot org
- Date: Fri, 20 Mar 2009 10:19:36 +0800
- Subject: 答复: Re: [PATCH] Support new target S+core 3 , a variant of S+core
Hi Joel and Don,
> > > Something that's missing from your patch is a ChangeLog.
> >
> > It's in the first post. Anyway, I have sent it again, and a NEWS
entry.
>
> I saw that. Thank you. I apologize if you feel it's an inconvenience,
> but anything to help the maintainers is welcome. The CONTRIBUTE file
> is fairly specific about "bundling" all the pieces together in an email.
> Now that I'm one of the maintainers, I can definitely understand
> the value of constantly having everything repeated æeverytime you
> send a patch. To give you an idea, most patches are non-obvious to
> me, and I frequently have to spend an hour or more to review each
> one of them. That's part of being new to the maintainer role, but
> any help in shortening the review time is definitely appreciated.
>
> > We have tested our changes on simulator, and on FPGA. Almost all
patterns
> > are passed. At now, we have about 35 failures, because some functions
we
> > don't have, and we think it's acceptable.
>
> You don't have to have clean results with 0 fail. What we ask is that
> each patch you submit does not introduce new failures (we can make
> exceptions, but they need to be discussed). What I do, usually, is
> running the testsuite before and then after the patch, and check
> the differences.
>
> PS: The changes to the NEWS file is a change in itself, and should
> be submitted following the same procedure as the other changes.
> This means it should be submitted as a patch, with a ChangeLog
> entry. I'm sorry if you feel that we are overwhelming you with
> procedure, but it's very easy to follow and once you've learnt it,
> it'll be a no-brainer.
>
> --
> Joel
I'v already reviewed the patch and it's ok for me. We tested score3 and
score7 on both
FPGA and simulator, no more fails occur and it won't affect other targets.
I think
Don also has the ability to be S+core maintainer.
Best regards,
Qinwei
Mail qinwei@sunnorth.com.cn
Phone +86-010-62981668-2102
Fax +86-010-62985972