This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
Re: $argc variable
On Mon, Nov 07, 2005 at 11:09:29AM +0000, Andrew STUBBS wrote:
> Daniel Jacobowitz wrote:
> >It's still in the review queue. I didn't like the implementation, but
> >I haven't had time to come up with a better one. If you feel like
> >helping... You'll notice no one else responded at the time when I
> >asked for comments.
>
> What, specifically, did you not like about the implementation?
>
> I'd be happy to have a bash at it, but it would be easier to avoid the
> same problems if I knew what they were.
Mostly, the coding style was very un-GNU. I also got the feeling that
there were better ways to do a lot of the string parsing, but I really
didn't spend much time looking at it (since I figured reimplementing
would be simpler in this case than FSF assignment).
--
Daniel Jacobowitz
CodeSourcery, LLC