This is the mail archive of the
gdb@sources.redhat.com
mailing list for the GDB project.
Re: remove enum from ppc-linux-tdep.c
On Sun, Jan 26, Daniel Jacobowitz wrote:
> On Sun, Jan 26, 2003 at 08:20:55PM +0100, Olaf Hering wrote:
> > Hi,
> >
> > this patch uses the defines from asm/elf.h instead of the hardcoded
> > values. Would that have any bad side effects? asm-ppc64 includes elf.h
> > via sigcontext.h and that will result in a syntax error.
>
>
> > +#include "<asm/elf.h>"
>
> First of all, that's a syntax error :)
sigh...
> Secondly, tdep stands for target dependant. This needs to work from
> any host platform. The right thing to do is probably to rename the
> enum: PPC_LINUX_ELF_NGREG, or something like that.
>
> [Or fix your headers. That's pretty bad namespace polution. It
> shouldn't do that.]
Ok, I will leave that to Will.
Thanks for the pointers.
Gruss Olaf
--
A: No.
Q: Should I include quotations after my reply?