Re: MIPS targets broken by dummy frame/regcache changes

[Daniel Jacobowitz <drow at mvista dot com>]

On Fri, Oct 18, 2002 at 07:41:50PM -0400, Andrew Cagney wrote:
> 
> >@@ -28,9 +29,7 @@
> > int
> > mips_linux_cannot_fetch_register (int regno)
> > {
> >-  if (regno >= FP_REGNUM)
> >-    return 1;
> >-  else if (regno == PS_REGNUM)
> >+  if (regno == PS_REGNUM)
> >     return 1;
> >   else if (regno == ZERO_REGNUM)
> >     return 1;
> >@@ -41,9 +40,7 @@ mips_linux_cannot_fetch_register (int re
> > int
> > mips_linux_cannot_store_register (int regno)
> > {
> >-  if (regno >= FP_REGNUM)
> >-    return 1;
> >-  else if (regno == PS_REGNUM)
> >+  if (regno == PS_REGNUM)
> >     return 1;
> >   else if (regno == ZERO_REGNUM)
> >     return 1;
> >
> >It's wrong.  First of all, you changed the behavior for registers above
> >FP_REGNUM, like UNUSED_REGNUM.  Secondly, FP_REGNUM did not become OK
> >to fetch/store after this patch.  Just the numbering changed.
> >
> >I'll fix it in a little bit.
> 
> Ulgh, what was I thinking.
> 
> The reggroup code will let this be fixed properly - can finally specify 
> exactly which registers should be saved/restored across an inferior 
> function call.

Looking forward to it!

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer