This is the mail archive of the gdb@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: DOS/Windows-specific code: source.c


On Tue, May 08, 2001 at 12:22:22PM -0400, DJ Delorie wrote:
>Eli Zaretskii <eliz@is.elta.co.il> writes:
>>     * source.c:openp()
>> 
>>     #ifdef _WIN32
>>       mode |= O_BINARY;
>>     #endif
>> 
>>I think this is obsolete and should be removed: defining
>>CRLF_SOURCE_FILES in xm-whatever should solve the underlying problem.
>
>What I do is this:
>
>#ifndef O_BINARY
>#define O_BINARY 0
>#endif
>
>Put that somewhere global, and then *always* use O_BINARY and don't
>worry about it.

gdb does this, too.  It does it in too many (7) places, though.
Shouldn't this be in a header file (defs.h?) somewhere?

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]