Re: FAIL: gdb.base/finish.exp: finish from char_func

[Michael Snyder <msnyder at redhat dot com>]

Fernando Nasser wrote:
> 
> This change would make this test very weak.
> 
> What target are you talking about and what character set?

Fernando, FYI, the fail was due to my checking in an inconsistent set
of sources.  The RE was expecting the value \001, while the program
was returning the character '1'.
> 
> We can add an "if" for this case until GDB adopts some official way
> to handle different character sets.  Some mechanism to handle that
> without loosen the tests too much will have to be devised then.

I'll get back to you with a change that I hope will answer Marks
issues and yours.  Although I seriously don't expect GDB to work
with a non-ASCII character set...


> Mark Kettenis wrote:
> >
> > Hi Michael,
> >
> > Running the testsuite on i586-pc-linux-gnu gives me the following failure:
> >
> >    FAIL: gdb.base/finish.exp: finish from char_func
> >
> > >From the .log file I see that the output is:
> >
> >    Value returned is $1 = 49 '1'^M
> >
> > which looks OK to me.  But in finish.exp there is the following
> > regular expression:
> >
> >    ".*Value returned is .* = 1 '.001'\r\n$gdb_prompt $"
> >
> > which I don't understand at all.  I would expect something like:
> >
> >    ".*Value returned is .* = \[0123456789\]* '1'\r\n$gdb_prompt $"
> >
> > (since you wouldn't want to assume that the character set in use is
> > ASCII).
> >
> > What's up?
> >
> > Mark
> 
> --
> Fernando Nasser
> Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
> 2323 Yonge Street, Suite #300
> Toronto, Ontario   M4P 2C9