This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PUSHED] gdb: Use std::abs instead of abs on LONGEST types
- From: Andrew Burgess <andrew dot burgess at embecosm dot com>
- To: gdb-patches at sourceware dot org
- Cc: Andrew Burgess <andrew dot burgess at embecosm dot com>
- Date: Thu, 27 Feb 2020 16:46:51 +0000
- Subject: [PUSHED] gdb: Use std::abs instead of abs on LONGEST types
Use std::abs so that we get the C++ overloaded version that matches
the argument type instead of the C abs function which is only for int
arguments.
There should be no user visible change after this commit.
gdb/ChangeLog:
* gdbtypes.c (create_array_type_with_stride): Use std::abs not
abs.
---
gdb/ChangeLog | 5 +++++
gdb/gdbtypes.c | 4 ++--
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c
index ef110b30445..d89df9f7409 100644
--- a/gdb/gdbtypes.c
+++ b/gdb/gdbtypes.c
@@ -1249,9 +1249,9 @@ create_array_type_with_stride (struct type *result_type,
negative stride in Fortran (this doesn't mean anything
special, it's still just a single element array) so do
consider that case when touching this code. */
- LONGEST element_count = abs (high_bound - low_bound + 1);
+ LONGEST element_count = std::abs (high_bound - low_bound + 1);
TYPE_LENGTH (result_type)
- = ((abs (stride) * element_count) + 7) / 8;
+ = ((std::abs (stride) * element_count) + 7) / 8;
}
else
TYPE_LENGTH (result_type) =
--
2.14.5