This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Remove "\nError: " suffix from nat/fork-inferior.c:trace_start_error warning message
- From: Pedro Alves <palves at redhat dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>, GDB Patches <gdb-patches at sourceware dot org>
- Date: Fri, 30 Aug 2019 20:54:11 +0100
- Subject: Re: [PATCH] Remove "\nError: " suffix from nat/fork-inferior.c:trace_start_error warning message
- References: <87ftljah3a.fsf@redhat.com> <20190830195102.8965-1-sergiodj@redhat.com>
On 8/30/19 8:51 PM, Sergio Durigan Junior wrote:
> Rationale: https://sourceware.org/ml/gdb-patches/2019-08/msg00651.html
>
> This very simple patch removes the "\nError: " suffix from the warning
> message printed by nat/fork-inferior.c:trace_start_error. This proved
> to just pollute the screen, causing things like:
>
> Starting program: /usr/bin/true
> warning: Could not trace the inferior process.
> Error:
> warning: ptrace: Permission denied
>
> This "Error: " string is not useful at all, and can confuse things,
> therefore let's just remove it and simplify the resulting messages:
>
> Starting program: /usr/bin/true
> warning: Could not trace the inferior process.
> warning: ptrace: Permission denied
>
> 2019-08-29 Sergio Durigan Junior <sergiodj@redhat.com>
>
> * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
> suffix from warning message.
OK.
Thanks,
Pedro Alves