This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix Gnulib glob.c resource leaks found by Coverity


Tom Tromey wrote:
> >>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
> Pedro> On 8/23/19 7:37 PM, Sergio Durigan Junior wrote:
> > > FWIW, I agree with Gary's approach here.  We discussed this
> > > internally and it's just too much work (and not a good use of
> > > Gary's time, IMHO) to update our gnulib copy and fix this error.
> > > Unfortunately, we will have to address this at a later moment.
> 
> Pedro> Agreed as well.  We'd like to get rid of the leaks (I think
> Pedro> it's the last issue in the whole Coverity-fixes series we've
> Pedro> been pushing for a few months), and Gary already spent a good
> Pedro> amount of time trying to upgrade gnulib, but it's revealing
> Pedro> tricky.  At this point I think it's better to backport the
> Pedro> leak fixes, and continue worrying about the gnulib upgrade
> Pedro> as a separate project.
> 
> Thanks for the info & sorry I didn't reply sooner.
> It's fine by me.

Thank you, I've pushed this.

Cheers,
Gary


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]