This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 13/14] Remove some defines from tui-data.h
- From: Tom Tromey <tom at tromey dot com>
- To: gdb-patches at sourceware dot org
- Cc: Tom Tromey <tom at tromey dot com>
- Date: Sun, 18 Aug 2019 11:27:34 -0600
- Subject: [PATCH 13/14] Remove some defines from tui-data.h
- References: <20190818172735.17477-1-tom@tromey.com>
This removes the HILITE and NO_HILITE defines from tui-data.h, in
favor of simply passing a bool to box_win.
gdb/ChangeLog
2019-08-18 Tom Tromey <tom@tromey.com>
* tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
(tui_unhighlight_win, tui_highlight_win)
(tui_win_info::make_window): Update.
* tui/tui-data.h (HILITE, NO_HILITE): Remove.
---
gdb/ChangeLog | 7 +++++++
gdb/tui/tui-data.h | 2 --
gdb/tui/tui-wingeneral.c | 10 +++++-----
3 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/gdb/tui/tui-data.h b/gdb/tui/tui-data.h
index dda15d1fbe1..6dfea41d49e 100644
--- a/gdb/tui/tui-data.h
+++ b/gdb/tui/tui-data.h
@@ -102,8 +102,6 @@ public:
#define CMD_NAME "cmd"
#define DATA_NAME "regs"
#define DISASSEM_NAME "asm"
-#define HILITE TRUE
-#define NO_HILITE FALSE
#define MIN_WIN_HEIGHT 3
#define MIN_CMD_WIN_HEIGHT 3
diff --git a/gdb/tui/tui-wingeneral.c b/gdb/tui/tui-wingeneral.c
index 5fa4cfd9eee..ab0363f856c 100644
--- a/gdb/tui/tui-wingeneral.c
+++ b/gdb/tui/tui-wingeneral.c
@@ -56,7 +56,7 @@ tui_delete_win (WINDOW *window)
/* Draw a border arround the window. */
static void
box_win (struct tui_win_info *win_info,
- int highlight_flag)
+ bool highlight_flag)
{
if (win_info && win_info->handle)
{
@@ -64,7 +64,7 @@ box_win (struct tui_win_info *win_info,
int attrs;
win = win_info->handle;
- if (highlight_flag == HILITE)
+ if (highlight_flag)
attrs = tui_active_border_attrs;
else
attrs = tui_border_attrs;
@@ -92,7 +92,7 @@ tui_unhighlight_win (struct tui_win_info *win_info)
&& win_info->can_highlight
&& win_info->handle != NULL)
{
- box_win (win_info, NO_HILITE);
+ box_win (win_info, false);
win_info->refresh_window ();
win_info->set_highlight (false);
}
@@ -106,7 +106,7 @@ tui_highlight_win (struct tui_win_info *win_info)
&& win_info->can_highlight
&& win_info->handle != NULL)
{
- box_win (win_info, HILITE);
+ box_win (win_info, true);
win_info->refresh_window ();
win_info->set_highlight (true);
}
@@ -138,7 +138,7 @@ tui_win_info::make_window ()
{
tui_gen_win_info::make_window ();
if (handle != NULL && can_box ())
- box_win (this, NO_HILITE);
+ box_win (this, false);
}
/* We can't really make windows visible, or invisible. So we have to
--
2.17.2