This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH][gdb] Make maint info sections print relocated addresses
- From: Tom Tromey <tom at tromey dot com>
- To: Tom de Vries <tdevries at suse dot de>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 15 Aug 2019 14:08:47 -0600
- Subject: Re: [PATCH][gdb] Make maint info sections print relocated addresses
- References: <20190814151458.GA22847@delia>
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> gdb/ChangeLog:
Tom> 2019-08-14 Tom de Vries <tdevries@suse.de>
Tom> * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
Tom> print_objfile_section_info.
Thanks.
Tom> + if (arg && strcmp (arg, "ALLOBJ") == 0)
Tom> + {
Tom> + arg = NULL;
Tom> + allobj = true;
Tom> + }
It took me a minute to understand that this was equivalent to the old
code. It looked like the intent was to use match_substring, but then
other code defeated that. If this was more user-facing I'd say "ALLOBJ"
should be replaced with a real option; but since this is a maint command
I would not bother.
This patch is ok. Thanks.
Tom