Re: [PATCH 06/15] Change tui_addr_is_displayed into a method

[Pedro Alves <palves at redhat dot com>]

On 8/14/19 5:21 PM, Tom Tromey wrote:
> diff --git a/gdb/tui/tui-winsource.c b/gdb/tui/tui-winsource.c
> index 1b2b4393fd9..e8e7061d0f2 100644
> --- a/gdb/tui/tui-winsource.c
> +++ b/gdb/tui/tui-winsource.c
> @@ -668,31 +668,3 @@ tui_line_is_displayed (int line,
>  
>    return is_displayed;
>  }
> -
> -
> -/* Answer whether a particular line number or address is displayed
> -   in the current source window.  */
> -int
> -tui_addr_is_displayed (CORE_ADDR addr, 
> -		       struct tui_source_window_base *win_info,
> -		       int check_threshold)

That intro comment is lost.  Move it...

> --- a/gdb/tui/tui-disasm.h
> +++ b/gdb/tui/tui-disasm.h
> @@ -51,6 +51,10 @@ struct tui_disasm_window : public tui_source_window_base
>  protected:
>  
>    void do_scroll_vertical (int num_to_scroll) override;
> +
> +private:
> +  bool addr_is_displayed (CORE_ADDR addr) const;

here?

Thanks,
Pedro Alves