This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFAv2 2/2] Add a selftest that checks documentation invariants.

From: Tom Tromey <tom at tromey dot com>
To: Philippe Waroquiers <philippe dot waroquiers at skynet dot be>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Tue, 06 Aug 2019 20:05:56 -0600
Subject: Re: [RFAv2 2/2] Add a selftest that checks documentation invariants.
References: <20190803133921.20154-1-philippe.waroquiers@skynet.be> <20190803133921.20154-3-philippe.waroquiers@skynet.be> <874l2u9mah.fsf@tromey.com> <1565130113.1435.10.camel@skynet.be>

Philippe> I have kept the code above, as strchr returns NULL if no \n
Philippe> is found, but it is normal to have a doc with just the
Philippe> first line (not terminated by a LF).
Philippe> In this case, we must still check that we have a . before
Philippe> the terminating null byte.

Thanks, that makes sense.

Tom

References:
- [RFAv2 0/2] Make first and last lines of 'command help documentation' consistent + add a test
  - From: Philippe Waroquiers
- [RFAv2 2/2] Add a selftest that checks documentation invariants.
  - From: Philippe Waroquiers
- Re: [RFAv2 2/2] Add a selftest that checks documentation invariants.
  - From: Tom Tromey
- Re: [RFAv2 2/2] Add a selftest that checks documentation invariants.
  - From: Philippe Waroquiers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]