This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Make info_symbol_command use lookup_minimal_symbol_by_pc
- From: Kevin Buettner <kevinb at redhat dot com>
- To: gdb-patches at sourceware dot org
- Cc: Christian Biesinger <cbiesinger at google dot com>
- Date: Tue, 6 Aug 2019 12:51:18 -0700
- Subject: Re: [PATCH] Make info_symbol_command use lookup_minimal_symbol_by_pc
- References: <20190805201902.15900-1-cbiesinger@google.com>
On Mon, 5 Aug 2019 15:19:02 -0500
"Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org> wrote:
> - for (objfile *objfile : current_program_space->objfiles ())
> - ALL_OBJFILE_OSECTIONS (objfile, osect)
> - {
...
Can it ever happen that symbols in either different objfiles and/or
sections will have the same address? I.e. some sort of alias?
Perhaps a weak symbol?
If so, it seems to me that the deleted code will print all such
symbols, whereas your proposed change will only print one of them.
I don't know if this ever happens or if it's an important case if it
should happen, but I'm wondering if you considered this possibility.
Kevin