This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][gdb/testsuite] Work around tcl bug in libsegfault.exp with check-read1


>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> The error occurs when accessing $env(LD_PRELOAD), in a branch where
Tom> "info exists env(LD_PRELOAD)" returns true. AFAIU, this is
Tom> https://core.tcl-lang.org/tcl/tktview?name=67fd4f973a "incorrect results of
Tom> 'info exists' when unset env var in one interp and check for existence from
Tom> another interp".

Nice diagnosis.

Tom>    if (read2 == NULL)
Tom>      {
Tom> -      unsetenv ("LD_PRELOAD");
Tom> +      setenv ("LD_PRELOAD", "", 1);

I think it would be good to mention some relevant part of the analysis
in a comment here.

Ok with that change.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]